Configure other than Backstage container to mount PVC volume to #582
Conversation
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gazarenkov
changed the title
| metadata: | ||
| name: myclaim | ||
| annotations: | ||
| rhdh.redhat.com/mount-path: "init-dynamic-plugins,backstage-backend" |
There was a problem hiding this comment.
| rhdh.redhat.com/mount-path: "init-dynamic-plugins,backstage-backend" | |
| rhdh.redhat.com/containers: "init-dynamic-plugins,backstage-backend" |
|
|
||
| * No or empty annotation means the volume will be mounted to the Backstage container only | ||
| * \* (asterik) means the volume will be mounted to all the containers | ||
| * Otherwise comma separated names of container will be used |
There was a problem hiding this comment.
| * Otherwise comma separated names of container will be used | |
| * Otherwise comma-separated names of containers will be used |
| @@ -56,6 +56,28 @@ metadata: | |||
|
|
|||
| In the example above the PVC called **myclaim** will be mounted to **/mount/path/from/annotation** directory | |||
|
|
|||
| #### Object annotation for mounting a volume to specific container(s) | |||
|
|
|||
| Using **rhdh.redhat.com/containers** annotation it is possible to define the containers where **PersistentVolumeClaim** object will be mounted. | |||
There was a problem hiding this comment.
This implies that the mount path will be the same in all the containers listed here, right?
What if I want to mount the PVC under specific paths for each container? IMO, we should handle this.
Thinking out loud, but how about extending the behavior of the rhdh.redhat.com/mount-path annotation above to include the container names, e.g.: rhdh.redhat.com/mount-path: 'install-dynamic-plugins:/mount/path1,backstage-backend:/mount/path2'?
| @@ -42,7 +42,7 @@ Some objects, such as: app-config, configmap-files, secret-files, dynamic-plugin | |||
|
|
|||
| #### Object annotation for mounting a volume to a specific path | |||
|
|
|||
| Using **rhdh.redhat.com/mount-path** annotation it is possible to define the directory where **PersistentVolumeClaim** object will be mounted to Backstage Container. | |||
| Using **rhdh.redhat.com/mount-path** annotation it is possible to define the directory where **PersistentVolumeClaim** object will be mounted. | |||
There was a problem hiding this comment.
The pvcs.yaml description in the table above should also be updated: https://github.com/redhat-developer/rhdh-operator/pull/582/files#diff-17ed18489a956f326ec0fe4040850c5bc9261d4631fb42da4c52891d74a59180L29
|
/assign |
Which issue(s) does this PR fix or relate to
https://issues.redhat.com/browse/RHIDP-4595
PR acceptance criteria
rhdh-operator.clusterserviceversion.yamlfile accordingly