ci: Fix issue that could skip PR container builds if the fork repo is outdated #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking out the PR fork repo could sometimes cause the "git diff" command to return an invalid revision range, like in [1]. This might happen if the fork repo is outdated. [1] https://github.com/redhat-developer/rhdh-operator/actions/runs/12417737622/job/34715972414?pr=582
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking out the PR fork repo could sometimes cause the "git diff" command to return an invalid revision range, like in [1].
This might happen if the fork repo is outdated.
To overcome this, this PR checks out the merge commit instead. That's also what GH does by default.
[1] https://github.com/redhat-developer/rhdh-operator/actions/runs/12417737622/job/34715972414?pr=582
Which issue(s) does this PR fix or relate to
https://github.com/redhat-developer/rhdh-operator/actions/runs/12417737622/job/34715972414?pr=582
I wanted to review and test #582 but realized no container was built for it. Based on the changes in that PR, it should have containers built.
PR acceptance criteria
rhdh-operator.clusterserviceversion.yamlfile accordinglyHow to test changes / Special notes to the reviewer
We need to merge this first to see it in action and validate the behavior.