Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIDP-2567 - Improve content in Chapter 2 of Configuring Dynamic Plugins guide #795

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

RHIDP-2567 - Improve content in Chapter 2 of Configuring Dynamic Plugins guide #795

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14cedcc
RHIDP-2567 - Improve content in Chapter 2 of Configuring Dynamic Plug…
Gerry-Forde Dec 14, 2024
590aad9
RHIDP-2567 - Improve content in Chapter 2 of Configuring Dynamic Plug…
Gerry-Forde Dec 14, 2024
2fe1308
Update assemblies/dynamic-plugins/assembly-installing-rhdh-plugins.adoc
Gerry-Forde Dec 16, 2024
caf565b
Merge branch 'main' into RHIDP-2567
Gerry-Forde Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions artifacts/attributes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,6 @@

:plugins-configure-book-url: https://docs.redhat.com/en/documentation/red_hat_developer_hub/{product-version}/html-single/configuring_dynamic_plugins/index
:plugins-configure-book-title: Configuring dynamic plugins

:plugins-ref-book-url: https://docs.redhat.com/en/documentation/red_hat_developer_hub/{product-version}/html-single/dynamic_plugins_reference/index#red-hat-supported-plugins
:plugins-ref-book-title: Dynamic plugins reference
7 changes: 7 additions & 0 deletions assemblies/dynamic-plugins/assembly-installing-rhdh-plugins.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ The dynamic plugin support is based on the backend plugin manager package, which

You can use the dynamic plugins that come preinstalled with {product} or install external dynamic plugins from a public NPM registry.

[TIP]
====
In your plugins configuration file, for preinstalled plugins, use the path specified in the preinstalled plugins tables in the link:{plugins-ref-book-url}#rhdh-supported-plugins[{plugins-ref-book-title}].

Use the plugin ID in your plugins' configuration file for external dynamic plugins that you download from an NPM registry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's that simple. How does RHDH find your downloaded plugin? Doesn't it need to be in the cluster somehow for this to work? @batzionb what advice do you give to Orchestrator plugin users?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have this documentation explaining what to put in the dynamic-plugins configmap

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider providing an example for each scenario to make it crystal clear what changes have to be made.

====

// Operator installation
include::../modules/dynamic-plugins/proc-config-dynamic-plugins-rhdh-operator.adoc[leveloffset=+2]

Expand Down
Loading