RHIDP-2567 - Improve content in Chapter 2 of Configuring Dynamic Plugins guide #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-795/ @ 12/16/24 20:13:05 |
hmanwani-rh
reviewed
Dec 16, 2024
assemblies/dynamic-plugins/assembly-installing-rhdh-plugins.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Heena Manwani <[email protected]>
nickboldt
reviewed
Dec 16, 2024
| ==== | ||
| In your plugins configuration file, for preinstalled plugins, use the path specified in the preinstalled plugins tables in the link:{plugins-ref-book-url}#rhdh-supported-plugins[{plugins-ref-book-title}]. | ||
|
|
||
| Use the plugin ID in your plugins' configuration file for external dynamic plugins that you download from an NPM registry. |
There was a problem hiding this comment.
I'm not sure it's that simple. How does RHDH find your downloaded plugin? Doesn't it need to be in the cluster somehow for this to work? @batzionb what advice do you give to Orchestrator plugin users?
There was a problem hiding this comment.
we have this documentation explaining what to put in the dynamic-plugins configmap
There was a problem hiding this comment.
I would consider providing an example for each scenario to make it crystal clear what changes have to be made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHIDP-2567 - Improve content in Chapter 2 of Configuring Dynamic Plugins guide
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
1.4
Add the relevant labels to the Pull Request.
Issue:
RHIDP-2567