Refactor StartDevMode to return a single object instead of multiple args #6886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔨 Deploy Preview deleted from internal cluster!
|
openshift-ci
bot
added
area/testing
valaparthvi
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
valaparthvi
commented
Jun 13, 2023
valaparthvi
requested review from
rm3l and
feloy
and removed request for
rnapoles-rh
valaparthvi
force-pushed
the
refactor-dev
branch
from
5c48e7b to
ec30ceb
Compare
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
refactor-dev
branch
from
ec30ceb to
8f8795d
Compare
openshift-merge-robot
removed
the
needs-rebase
valaparthvi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Parthvi Vala <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
feloy
approved these changes
Jun 16, 2023
openshift-ci
bot
added
the
lgtm
|
/override OpenShift-Integration-tests/OpenShift-Integration-tests [odo] ✗ Syncing files into the container [4ms]
[odo] Error occurred on Push - watch command was unable to push component: failed to sync to component with name mynode: failed to sync to component with name mynode: unable push files to pod: error while streaming command: error sending request: Post "https://c100-e.eu-de.containers.cloud.ibm.com:31049/api/v1/namespaces/cmd-remove-binding-test71qon/pods/mynode-app-57d77b45bb-xmjvz/exec?command=tar&command=xf&command=-&command=-C&command=%2Fprojects&command=--no-same-owner&container=runtime&stderr=true&stdin=true&stdout=true": dial tcp: lookup c100-e.eu-de.containers.cloud.ibm.com: operation was canceled
[odo]
[odo]
[odo] ↪ Dev mode
[odo] Status:
[odo] Watching for changes in the current directory /tmp/3271381815
[odo]
[odo] Keyboard Commands:
[odo] [Ctrl+c] - Exit and delete resources from the cluster
[odo] [p] - Manually apply local changes to the application on the cluster
[odo] I0616 11:43:50.565792 17461 implem.go:114] The path for preference file is /tmp/4157871543/preference.yaml
[odo] I0616 11:43:50.566355 17461 segment.go:264] Checking telemetry enable status
[odo] I0616 11:43:50.566388 17461 segment.go:282] Sending telemetry disabled by env variable
[odo] Cleaning resources, please wait
[odo] I0616 11:43:50.614310 17461 delete.go:176] Ignoring resource: servicebindings/my-nodejs-app-cluster-sample-ocp; it does not exist on the cluster
[odo] I0616 11:43:50.657616 17461 all.go:46] starting to concurrently query 200 APIs
[odo] I0616 11:43:50.659814 17461 all.go:62] fired up all goroutines to query APIs
[odo] I0616 11:43:51.528455 17461 all.go:67] all goroutines have returned in 870.837356ms
[odo] I0616 11:43:51.528485 17461 all.go:76] query result: objects=546
[odo] ✗ Dev mode interrupted by user
Deleting project: cmd-remove-binding-test71qon
Running oc with args [oc delete project cmd-remove-binding-test71qon --wait=false] and odo env: []
[oc] project.project.openshift.io "cmd-remove-binding-test71qon" deleted
Setting current dir to: /go/odo_1/tests/integration
Deleting dir: /tmp/3271381815
Deleting dir: /tmp/4157871543
<< Timeline
[FAILED] Expected
<string>:
to contain substring
<string>: not found |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override windows-integration-test/Windows-test [FAILED] No future change is possible. Bailing out early after 1.212s.
Running oc.exe with args [oc get csv -o jsonpath={.items[?(@.status.phase=="Succeeded")].metadata.name}] and odo env: []
Expected
<int>: 1
to match exit code:
<int>: 0
------------
I0616 05:03:50.613347 6492 util.go:198] path C:\Users\Administrator.ANSIBLE-T
EST-VS\AppData\Local\Temp\2170439783\devfile.yaml doesn't exist, skipping it [92m
? [97mDo you want to list services from:[m [36m[Use arrows to move, type to filter][m [36m
> current namespace[m[61X[61C
all accessible namespaces[53X[53C[?25h[?25l[HI[?25h
======================
Unexpected error:
<*xpty.errPassthroughTimeout | 0xc0008cc020>: {
error: <*errors.errorString | 0xc0008cc010>{
s: "passthrough i/o timeout",
},
}
passthrough i/o timeout
occurred
In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/4170/tests/helper/helper_interactive.go:111 @ 06/16/23 05:05:50.661
------------------------------
Summarizing 3 Failures:
[FAIL] odo devfile deploy command tests deploying devfile with long-running exec when Automount volumes are present in the namespace [It] should mount the volumes
C:/Users/Administrator.ANSIBLE-TEST-VS/4170/tests/helper/helper_cmd_wrapper.go:120
[FAIL] odo add binding interactive command tests when running a deployment when binding to a service in a different namespace [It] should successfully add binding without devfile
C:/Users/Administrator.ANSIBLE-TEST-VS/4170/tests/helper/helper_interactive.go:111
[FAIL] odo describe/list binding command tests when creating a component with a binding as environment variables (service in namespace "") when Starting a Pg service [BeforeEach] when running dev session when changing the current namespace should list the binding with --namespace flag - command: [list binding]
C:/Users/Administrator.ANSIBLE-TEST-VS/4170/tests/helper/helper_generic.go:58
|
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override Pull Request Website Preview / deploy-prev |
|
@valaparthvi: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override deploy-preview |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: deploy-preview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
temporarily deployed
to
internal
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/area testing
/kind code-refactoring
What does this PR do / why we need it:
I find it confusing to work with multiple args returned by
StartDevMode, using a single object makes it easier.Which issue(s) this PR fixes:
Latest commit Fixes #6876
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: