Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send tests results to Sheet #6873

Merged
merged 5 commits into from
Jun 16, 2023
Merged

Send tests results to Sheet #6873

merged 5 commits into from
Jun 16, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 7, 2023

What type of PR is this:

/kind feature
/area testing

What does this PR do / why we need it:

Send data collected into a junit file during integration tests to a Goole Sheet

Which issue(s) this PR fixes:

Fixes #6451

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 7, 2023
@netlify
Copy link

netlify bot commented Jun 7, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 22fe6eb
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/648ac5a511c8ca000822b7fd

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Jun 7, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and valaparthvi June 7, 2023 14:38
@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 763ae09 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023 •
edited
Loading

NoCluster Tests on commit 763ae09 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023 •
edited
Loading

Unit Tests on commit 763ae09 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023 •
edited
Loading

Validate Tests on commit 763ae09 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the tests-6451/send-tests-results branch 2 times, most recently from c6448c3 to 3506489 Compare June 7, 2023 15:07
@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023 •
edited
Loading

Windows Tests (OCP) on commit 763ae09 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023 •
edited
Loading

OpenShift Tests on commit 763ae09 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023 •
edited
Loading

Kubernetes Tests on commit 763ae09 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the tests-6451/send-tests-results branch 3 times, most recently from 890e4be to 0c4df27 Compare June 7, 2023 15:40
@feloy feloy changed the title Send tests results to Sheet [wip] Send tests results to Sheet Jun 7, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 7, 2023
@feloy feloy force-pushed the tests-6451/send-tests-results branch 2 times, most recently from 16529cd to 3231ca4 Compare June 7, 2023 18:07
@odo-robot
Copy link

odo-robot bot commented Jun 7, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 24db607 finished with errors.
View logs: TXT HTML

@feloy feloy force-pushed the tests-6451/send-tests-results branch 3 times, most recently from e26e88c to cc19c96 Compare June 7, 2023 19:50
@feloy feloy force-pushed the tests-6451/send-tests-results branch from cc19c96 to 001c43d Compare June 7, 2023 19:57
@feloy feloy requested a review from rm3l June 8, 2023 06:10
@feloy feloy changed the title [wip] Send tests results to Sheet Send tests results to Sheet Jun 8, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 8, 2023
rm3l
rm3l reviewed Jun 8, 2023
View reviewed changes
.ibm/tools/tests-results/go.mod Outdated
@@ -0,0 +1,29 @@
module github.com/feloy/junit-collector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the module to something like github.com/redhat-developer/junit-collector?

@feloy feloy changed the title Send tests results to Sheet [wip] Send tests results to Sheet Jun 9, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 9, 2023
valaparthvi
valaparthvi reviewed Jun 9, 2023
View reviewed changes
.ibm/tools/tests-results/main.go Outdated
Comment on lines 64 to 69
oldDate := time.Now().Add(-15 * 24 * time.Hour)
fmt.Printf("Deleting entries before: %s\n", oldDate.Format("2006-01-02"))
err := db.Clean(ctx, spreadsheetId, oldDate.Format("2006-01-02"))
if err != nil {
panic(err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be removed. An automation task has been setup to clean 15 days old data every night.

@valaparthvi
Copy link
Contributor

Is it possible to also set this up for podman tests running via GH actions.

@feloy feloy closed this Jun 14, 2023
@feloy feloy reopened this Jun 14, 2023
@feloy feloy closed this Jun 14, 2023
@feloy feloy reopened this Jun 14, 2023
@feloy feloy closed this Jun 14, 2023
@feloy feloy reopened this Jun 14, 2023
@feloy feloy force-pushed the tests-6451/send-tests-results branch from c722245 to 22fe6eb Compare June 15, 2023 08:02
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.8% 5.8% Duplication

@feloy feloy changed the title [wip] Send tests results to Sheet Send tests results to Sheet Jun 16, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 16, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 16, 2023
@feloy
Copy link
Contributor Author

feloy commented Jun 16, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
Known issue (#6876)

@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
Known issue (#6876)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jun 16, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated

@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jun 16, 2023

/override "SonarCloud Code Analysis"
Code duplication on mocks

@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

@feloy: Overrode contexts on behalf of feloy: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"
Code duplication on mocks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit cd9cc55 into redhat-developer:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l left review comments

@valaparthvi valaparthvi valaparthvi approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@valaparthvi valaparthvi

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flakes analysis on IBM cloud tests
4 participants
@feloy @valaparthvi @rm3l @openshift-merge-robot