Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odo list component shows components running on podman #6366

Merged
merged 9 commits into from
Dec 6, 2022
Merged

odo list component shows components running on podman #6366

merged 9 commits into from
Dec 6, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Dec 1, 2022

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6297

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Dec 1, 2022
@netlify
Copy link

netlify bot commented Dec 1, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e614b0f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/638f106da9ef280008a988b4

@odo-robot
Copy link

odo-robot bot commented Dec 1, 2022 •
edited
Loading

NoCluster Tests on commit b150969 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 1, 2022 •
edited
Loading

Unit Tests on commit b150969 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6297/podman/odo-list-component branch from 3b1305c to 8751a8b Compare December 1, 2022 09:35
@odo-robot
Copy link

odo-robot bot commented Dec 1, 2022 •
edited
Loading

Validate Tests on commit b150969 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 1, 2022 •
edited
Loading

Kubernetes Tests on commit b150969 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 1, 2022 •
edited
Loading

Windows Tests (OCP) on commit b150969 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 1, 2022 •
edited
Loading

OpenShift Tests on commit b150969 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6297/podman/odo-list-component branch from 8751a8b to 9af2719 Compare December 1, 2022 14:32
@feloy feloy requested review from rm3l and removed request for anandrkskd December 1, 2022 17:55
@feloy
Copy link
Contributor Author

feloy commented Dec 5, 2022

Blocked by #6374

@feloy feloy force-pushed the feature-6297/podman/odo-list-component branch 3 times, most recently from 7e57942 to e19e2ea Compare December 5, 2022 10:45
rm3l
rm3l reviewed Dec 5, 2022
View reviewed changes
pkg/podman/version.go Outdated Show resolved Hide resolved
@feloy feloy force-pushed the feature-6297/podman/odo-list-component branch from e19e2ea to 961dc84 Compare December 5, 2022 12:21
@feloy feloy changed the title [WIP] odo list component shows components running on podman odo list component shows components running on podman Dec 5, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Dec 5, 2022
@feloy feloy requested a review from rm3l December 5, 2022 13:50
rm3l
rm3l requested changes Dec 5, 2022
View reviewed changes
pkg/podman/version.go Show resolved Hide resolved
pkg/odo/cli/list/component/list.go Outdated Show resolved Hide resolved
pkg/podman/podman.go Show resolved Hide resolved
pkg/podman/podman.go Show resolved Hide resolved
pkg/podman/podman.go Show resolved Hide resolved
pkg/podman/podman.go Show resolved Hide resolved
@feloy feloy force-pushed the feature-6297/podman/odo-list-component branch from 0c69883 to 7937a74 Compare December 5, 2022 17:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

rm3l
rm3l approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - works great for me!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 6, 2022
@feloy
Copy link
Contributor Author

feloy commented Dec 6, 2022

/override ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0c008c6 into redhat-developer:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo list: odo list component should show components running on podman
3 participants
@feloy @rm3l @openshift-merge-robot