Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo list: odo list component should show components running on podman #6297

Closed
3 tasks
Tracked by #5871
rm3l opened this issue Nov 10, 2022 · 2 comments · Fixed by #6366
Closed
3 tasks
Tracked by #5871

odo list: odo list component should show components running on podman #6297

rm3l opened this issue Nov 10, 2022 · 2 comments · Fixed by #6366
Assignees
Labels
area/odo-on-podman Issues or PRs related to running odo against Podman
Milestone

Comments

@rm3l
Copy link
Member

rm3l commented Nov 10, 2022

Acceptance Criteria:

  • Default behavior: listing everything from all accessible platforms
  • If platform is specified, limit listing to that platform
  • Do not fail if K8s cluster or podman are not available

Examples

$ odo list component        
 ✓  Listing components from namespace 'default' [389ms]
 NAME                PROJECT TYPE  RUNNING IN  MANAGED RUNNING ON
 * my-quarkus-app-2  Quarkus       Dev,Deploy        Unknown  Cluster (<cluster name from Kubeconfig>)
 * my-quarkus-app-2  Quarkus       Dev        Unknown  Podman


NOTES:

@rm3l rm3l added this to odo Project Nov 10, 2022
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 10, 2022
@rm3l rm3l changed the title odo list odo list component should show components running on podman odo list: odo list component should show components running on podman Nov 17, 2022
@rm3l rm3l added the area/odo-on-podman Issues or PRs related to running odo against Podman label Nov 17, 2022
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 23, 2022
@rm3l rm3l added this to the v3.4.0 🚀 milestone Nov 23, 2022
@feloy feloy moved this to In Review 👀 in odo Project Dec 1, 2022
@feloy
Copy link
Contributor

feloy commented Dec 5, 2022

It has not been discussed as acceptance criteria, do we want to do the same for the component part of odo list?

@rm3l
Copy link
Member Author

rm3l commented Dec 6, 2022

It has not been discussed as acceptance criteria, do we want to do the same for the component part of odo list?

I would say yes (to be consistent), but isn't it the same code (as in odo list component) that is called to handle the component part of odo list?

Repository owner moved this from In Review 👀 to Done ✅ in odo Project Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/odo-on-podman Issues or PRs related to running odo against Podman
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants