Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note regarding image visibility for odo deploy #6191

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Note regarding image visibility for odo deploy #6191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f6e590
Note regarding image visibility for odo deploy
dharmit Oct 4, 2022
eaea5a6
Update docs/website/docs/user-guides/advanced/deploy/_running_deploy.mdx
dharmit Oct 6, 2022
e94b1af
Update docs/website/docs/user-guides/advanced/deploy/_running_deploy.mdx
dharmit Oct 6, 2022
93d2a86
Update docs/website/docs/user-guides/advanced/deploy/_running_deploy.mdx
dharmit Oct 6, 2022
b3db77b
Add image visibility note to deploy doc
dharmit Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/website/docs/_imageregistrynote.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
:::note
Depending upon the container registry specified in the `devfile.yaml`, the access for container image
pushed by `odo deploy` may be private by default. For example: images pushed to [Quay.io](https://quay.io). Change the
image visibility appropriately in order to run `odo deploy` successfully.
:::
8 changes: 7 additions & 1 deletion docs/website/docs/command-reference/deploy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,13 @@ components:
image: {{CONTAINER_IMAGE}}
```

Note that the `uri` for the Dockerfile could also be an HTTP or HTTPS URL.
:::note
The `uri` for the Dockerfile could also be an HTTP or HTTPS URL.
:::

import Note from '../_imageregistrynote.mdx';

<Note />

### Running the command
```shell
Expand Down
3 changes: 3 additions & 0 deletions docs/website/docs/user-guides/advanced/deploy/_running_deploy.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,7 @@ Your Devfile has been successfully deployed

Your application has now been deployed to the Kubernetes cluster with Deployment, Service, and Ingress resources.

import Note from '../../../_imageregistrynote.mdx';

<Note />
Test your application by visiting the `DOMAIN_NAME` variable that you had set in the `devfile.yaml`.