Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note regarding image visibility for odo deploy #6191

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Note regarding image visibility for odo deploy #6191

merged 5 commits into from
Oct 6, 2022

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Oct 4, 2022

Signed-off-by: Dharmit Shah [email protected]

What type of PR is this:
/kind documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6107

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Oct 4, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit b3db77b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/633e78ac2d589e0009bb3d3a
😎 Deploy Preview https://deploy-preview-6191--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from cdrage and feloy October 4, 2022 11:31
@odo-robot
Copy link

odo-robot bot commented Oct 4, 2022 •
edited
Loading

Unit Tests on commit b1d4b27 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 4, 2022 •
edited
Loading

Validate Tests on commit b1d4b27 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 4, 2022 •
edited
Loading

Windows Tests (OCP) on commit b1d4b27 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 4, 2022 •
edited
Loading

Kubernetes Tests on commit b1d4b27 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 4, 2022 •
edited
Loading

OpenShift Tests on commit b1d4b27 finished successfully.
View logs: TXT HTML

rm3l
rm3l reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you also include this note somewhere in the command reference page for odo deploy? Thanks.

@dharmit
Copy link
Member Author

dharmit commented Oct 6, 2022

LGTM, but can you also include this note somewhere in the command reference page for odo deploy? Thanks.

Added.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 6, 2022
@feloy
Copy link
Contributor

feloy commented Oct 6, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4d82c4d into redhat-developer:main Oct 6, 2022
@dharmit dharmit deleted the fix-6107 branch October 20, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage requested changes

@rm3l rm3l rm3l approved these changes

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

@cdrage cdrage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert user public vs private registry when pushing image
5 participants
@dharmit @feloy @rm3l @cdrage @openshift-merge-robot