Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parametrized integration tests #5826

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Fix parametrized integration tests #5826

merged 2 commits into from
Jun 20, 2022

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind tests

What does this PR do / why we need it:
This PR makes an attempt at fixing dynamically generated specs. We have been using for loops with our integration tests, but it doesn't work as expected. The fix introduced with this PR attempts at fixing that.

Which issue(s) this PR fixes:

Fixes #5814

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. Debug tests, make sure correct data is taken into account.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 14, 2022
@netlify
Copy link

netlify bot commented Jun 14, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 00d1fb3
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62b0516b0d623b00088db84a

@openshift-ci openshift-ci bot requested review from feloy and rnapoles-rh June 14, 2022 11:20
@valaparthvi valaparthvi requested a review from rm3l June 14, 2022 11:28
@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022 •
edited
Loading

Unit Tests on commit 2d1982c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022 •
edited
Loading

Windows Tests (OCP) on commit 2d1982c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022 •
edited
Loading

Kubernetes Tests on commit 2d1982c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022 •
edited
Loading

OpenShift Tests on commit 2d1982c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022 •
edited
Loading

Validate Tests on commit 2d1982c finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

/retest

@feloy
Copy link
Contributor

feloy commented Jun 20, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 20, 2022
@feloy feloy removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 20, 2022
@valaparthvi valaparthvi changed the title WIP: Fix parametrized integration tests Fix parametrized integration tests Jun 20, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 20, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

rm3l
rm3l reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for fixing these tests, @valaparthvi!

tests/integration/devfile/cmd_delete_test.go Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jun 20, 2022
@valaparthvi
Copy link
Contributor Author

/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jun 20, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 20, 2022
@openshift-ci openshift-ci bot merged commit bf71fa3 into redhat-developer:main Jun 20, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@valaparthvi @cdrage
Fix parametrized integration tests (redhat-developer#5826)
82fda10 
* Fix parametrized integration tests

Signed-off-by: Parthvi Vala <[email protected]>

* Fix test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy left review comments

@rm3l rm3l rm3l left review comments

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamically generated specs with for loop do not work with ginkgo
3 participants
@valaparthvi @feloy @rm3l