Merge c1c84ea into d567784

tests/integration/cmd_namespace_test.go

@@ -22,13 +22,13 @@ var _ = Describe("odo create/delete/list/set namespace/project tests", func() {
 	AfterEach(func() {
 		helper.CommonAfterEach(commonVar)
 	})
-
 	for _, commandName := range []string{"namespace", "project"} {
-
+		// this is a workaround to ensure that the for loop works with `It` blocks
+		commandName := commandName
 		Describe("create "+commandName, func() {
+
 			namespace := fmt.Sprintf("%s-%s", helper.RandString(4), commandName)
 
-			// TODO: Remove for loop; find a way to use DescribeTable
 			It(fmt.Sprintf("should successfully create the %s", commandName), func() {
 				helper.Cmd("odo", "create", commandName, namespace, "--wait").ShouldPass()
 				defer func(ns string) {

tests/integration/devfile/cmd_delete_test.go

@@ -48,6 +48,8 @@ var _ = Describe("odo delete command tests", func() {
 			},
 		},
 	} {
+		// this is a workaround to ensure that the for loop works with `It` blocks
+		ctx := ctx
 		When(ctx.title, func() {
 			BeforeEach(func() {
 				// Hardcoded names from `ctx.devfileName`

tests/integration/devfile/cmd_describe_binding_test.go

@@ -188,6 +188,8 @@ var _ = Describe("odo describe binding command tests", func() {
 			},
 		},
 	} {
+		// this is a workaround to ensure that for loop works well with `It` blocks
+		ctx := ctx
 		When(ctx.title, func() {
 			cmpName := "my-nodejs-app"
 			BeforeEach(func() {

tests/integration/devfile/cmd_devfile_build_images_test.go

@@ -102,6 +102,8 @@ var _ = Describe("odo devfile build-images command tests", func() {
 				},
 			},
 		} {
+			// this is a workaround to ensure that the for loop works with `It` blocks
+			scope := scope
 			It(fmt.Sprintf("should build image via %s if build context references PROJECT_SOURCE env var", scope.name), func() {
 				stdout := helper.Cmd("odo", "build-images").AddEnv(scope.envvars...).ShouldPass().Out()
 				lines, err := helper.ExtractLines(stdout)
@@ -144,6 +146,8 @@ var _ = Describe("odo devfile build-images command tests", func() {
 				},
 			},
 		} {
+			// this is a workaround to ensure that the for loop works with `It` blocks
+			scope := scope
 			It(fmt.Sprintf("should build image via %s by defaulting build context to devfile path", scope.name), func() {
 				stdout := helper.Cmd("odo", "build-images").AddEnv(scope.envvars...).ShouldPass().Out()
 				lines, err := helper.ExtractLines(stdout)

tests/integration/devfile/cmd_devfile_deploy_test.go

@@ -61,6 +61,8 @@ var _ = Describe("odo devfile deploy command tests", func() {
 			},
 		},
 	} {
+		// this is a workaround to ensure that the for loop works with `It` blocks
+		ctx := ctx
 
 		When(ctx.title, func() {
 			// from devfile
@@ -214,6 +216,9 @@ var _ = Describe("odo devfile deploy command tests", func() {
 				},
 			},
 		} {
+			// this is a workaround to ensure that the for loop works with `It` blocks
+			scope := scope
+
 			It(fmt.Sprintf("should build image via %s if build context references PROJECT_SOURCE env var", scope.name), func() {
 				stdout := helper.Cmd("odo", "deploy").AddEnv(scope.envvars...).ShouldPass().Out()
 				lines, err := helper.ExtractLines(stdout)
@@ -258,6 +263,9 @@ var _ = Describe("odo devfile deploy command tests", func() {
 				},
 			},
 		} {
+			// this is a workaround to ensure that the for loop works with `It` blocks
+			scope := scope
+
 			It(fmt.Sprintf("should build image via %s by defaulting build context to devfile path", scope.name), func() {
 				stdout := helper.Cmd("odo", "deploy").AddEnv(scope.envvars...).ShouldPass().Out()
 				lines, err := helper.ExtractLines(stdout)