Odo v3: Move odo registry to odo preference registry, remove unused pref. settings #5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/feature
|
✔️ Deploy Preview for odo-docusaurus-preview canceled. 🔨 Explore the source changes: fffe0a7 🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6203c9ca534acb00071fedcd |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/retest |
|
/retest-required |
cdrage
force-pushed
the
move-registry-to-preference
branch
from
6ddf670 to
59cbe66
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
cdrage
changed the title
cdrage
changed the title
cdrage
force-pushed
the
move-registry-to-preference
branch
3 times, most recently
from
cc5bf6b to
d3bc310
Compare
|
Ready for reviews! No longer WIP and I've updated the description / added more tests. |
cdrage
force-pushed
the
move-registry-to-preference
branch
3 times, most recently
from
c6eae3e to
1599702
Compare
feloy
reviewed
Feb 8, 2022
pkg/component/component.go
Outdated
| } else { | ||
| // Set the required prefix into componentName | ||
| prefix = *cfg.NamePrefix() | ||
| // V2 Change -> V3 |
There was a problem hiding this comment.
Could you please remove this commented code?
pkg/odo/cli/preference/unset.go
Outdated
| } | ||
| // For now, the --help page is too large listing all unset values too. | ||
| // Just show one example of how to unset a value. | ||
| //for _, property := range preference.GetSupportedParameters() { |
There was a problem hiding this comment.
I'm not sure it is necessary to keep old code here. You could remove the code, and explain why we only display for 1st parameter.
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind cleanup /kind tests /kind documentation Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind feature **What does this PR do / why we need it:** This PR does the following: - Moves "registry" to preference - Gets rid of unused preference configuration options - Reorders the parameters for preference for the usage in --help **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> redhat-developer#5402 **PR acceptance criteria:** - [X] Unit test - [X] Integration test - [X] Documentation **How to test changes / Special notes to the reviewer:**
cdrage
force-pushed
the
move-registry-to-preference
branch
from
1599702 to
fffe0a7
Compare
|
Thanks for the comments @feloy I've updated the PR as well as made changes based on your feedback. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test v4.9-integration-e2e Infra errors |
|
/test v4.9-integration-e2e |
|
/test v4.9-integration-e2e |
kadel
pushed a commit
to kadel/odo
that referenced
this pull request
Feb 21, 2022
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind cleanup /kind tests /kind documentation Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind feature **What does this PR do / why we need it:** This PR does the following: - Moves "registry" to preference - Gets rid of unused preference configuration options - Reorders the parameters for preference for the usage in --help **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> redhat-developer#5402 **PR acceptance criteria:** - [X] Unit test - [X] Integration test - [X] Documentation **How to test changes / Special notes to the reviewer:**
cdrage
added a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind cleanup /kind tests /kind documentation Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind feature **What does this PR do / why we need it:** This PR does the following: - Moves "registry" to preference - Gets rid of unused preference configuration options - Reorders the parameters for preference for the usage in --help **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> redhat-developer#5402 **PR acceptance criteria:** - [X] Unit test - [X] Integration test - [X] Documentation **How to test changes / Special notes to the reviewer:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
This PR does the following:
odo registrytoodo preference registryWhich issue(s) this PR fixes:
#5402
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: