integrating odo registry into odo preference

[kadel]

odo preference

Configures odo behavior like timeouts or registries that odo uses.

The behavior is mostly the same as in v2. We can just remove some fields from the preference.

• NamePrefix - remove
• BuildTimeout - remove
• Timeout - add explanations
• PushTimeout - add explanations
• Ephemeral - keep
• ConsentTelemetry - keep
• UpdateNotification - keep

The odo registry command should be integrated into odo preference as odo preference registry subcommand and removed from top level commands.

odo preference view should include list of the configured registries

examples

odo preference registry add CheRegistry https://che-devfile-registry.openshift.io

odo preference registry list

odo preference view

odo preference set UpdateNotification false

[dharmit]

• Timeout - add explanations

• PushTimeout - add explanations

We have been using int for all timeouts so far. I suggest using time.Duration for it. We can use DurationVar instead of IntVar from cobra point of view.

[kadel]

We have been using int for all timeouts so far. I suggest using time.Duration for it. We can use DurationVar instead of IntVar from cobra point of view.

What is the benefit o using DurationVar if the user will always specify timeout in seconds?

[cdrage]

Mind if I get explanations for the changes?

For:

NamePrefix - remove - I understand this, we are just going to automatically create the component names.
BuildTimeout - remove - what do we replace this with? do we just implement a hardcoded default?
Timeout - add explanations - What kind of explanation? Does this take over build timeout?
PushTimeout - add explanations - explain that this is for deploy or something?

ping @kadel

[dharmit]

What is the benefit o using DurationVar if the user will always specify timeout in seconds?

Two benefits that I can think of:

• Not having to convert int to time.Duration as the values are now in time.Duration by default.
• Clearer CLI documentation, IMO. For example, odo watch -h from main branch looks like:

  $ odo watch -h
  ....
  --delay int              Time in seconds blah blah blah (default 1)
  ....

  But with --delay being set to DurationVar, here it is:

  $ odo watch -h
  ....
  --delay duration         Time in seconds blah blah blah (default 1s)
  ....

[cdrage]

Also, registrycachetime still exists in odo code, see: https://github.com/redhat-developer/odo/search?q=registrycachetime&type=code

Are we still keeping that variable too?

[kadel]

BuildTimeout - remove - what do we replace this with? do we just implement a hardcoded default? Timeout - add explanations - What kind of explanation? Does this take over build timeout? PushTimeout - add explanations - explain that this is for deploy or something?

@cdrage I'm afraid that you will have to check code what those timeouts actually do. I don't remember from top of my head and the description that we have for them doesn't help at all. :-/

Also, registrycachetime still exists in odo code, see: https://github.com/redhat-developer/odo/search?q=registrycachetime&type=code
Are we still keeping that variable too?

Yes, it will be still in use so we should keep it.

[cdrage]

#5428

Has been merged in!

[feloy]

Reopening the issue as the odo registry command still exists