Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the docs #1826

Merged

Conversation

dimakis
Copy link
Contributor

@dimakis dimakis commented Mar 6, 2023

Closes #

Verification Steps

  1. Do x
  2. Do y

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@dimakis dimakis requested a review from jackdelahunt March 6, 2023 15:25
@jackdelahunt jackdelahunt merged commit 8792784 into redhat-developer:deregister Mar 6, 2023
jackdelahunt pushed a commit that referenced this pull request Mar 7, 2023
dimakis added a commit that referenced this pull request Mar 8, 2023
* Enterprise crete kafka interactive (#1819)

* refactor: moving list enterprise clusters to util package

* feat: start of interactive enterprise create

* refactor: refactor of create kafka ams checks for enterprise quota (#1822)

* feat: when using dedicated with kafka create, we now check the capacity
of the cluster

* refactor: refactor of the interactive create kafka cmd

* refactor: refactoring dedicated list to use refactored search string func

* refactor: refactor and addition of name + id of cluster in prompt

* refactor: refactor to functional create enterprise flow with some updates based on reviews

* Add machine pool logic (#1795)

* feat: addition of the new dedicated command to select ocm cluster

* feat: addition of getting machine pools and hitting the register cluster endpoint in KFM

* refactor: addition of close ocm connection

* fix: addition of autoscaling check logic

* refactor: addresses commments made in PR

* refactor: addresses comments in review

* feat: addition of the addon installation flow

* feat: addition of cluster-id flag

* refactor: addresses some further comments in the review

* feat: addition of localization

* refactor: addition of error when user has no valid clusters

* chore(vendor): update vendoring (#1798)

* Add cluster id to create kafka (#1804)

* feat: addition of descriptions and examples to dedicated

* feat: Allows the CLI to install stage env addons when terraforming customer-cloud dataplane clusters

* refactor: the default api url is now set when creating a connection instead of in the registercluster cmd file

* refactor: update some func and var names

* refactor: add cluster-id flag to create kafka cmd to allow kafka creation on CC cluster

* refactor: doc and small refactor

* refactor: Refactor ocm methods out of register cmd file (#1807)

* feat: addition of descriptions and examples to dedicated

* feat: Allows the CLI to install stage env addons when terraforming customer-cloud dataplane clusters

* refactor: extraction of clustermgmt funcs from register to own dir

* refactor: addresses cluster pagination and refactor of ocm functions

* feat: added deregister command

* refactor: imrpoved quality of deregister command

* chore: added localisation to deregister command

* feat: deregister now waits for all kafkas to be deleted

* fix: better logging when deleting kafka

* refactor: getting cluster list now ask kfm then ocm

* chore: remove unused fields

* fix: edge case handling in deregister

* docs: update the docs (#1826)

* refactor: print the httpresponse (#1827)

* fix: fixing broken lints

* chore: rebase changes

---------

Co-authored-by: Dimitri Saridakis <[email protected]>
Co-authored-by: Ramakrishna Pattnaik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants