Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added de-register command #1812

Merged
merged 23 commits into from
Mar 8, 2023
Merged

feat: added de-register command #1812

merged 23 commits into from
Mar 8, 2023

Conversation

jackdelahunt
Copy link
Contributor

@jackdelahunt jackdelahunt commented Feb 20, 2023 •
edited
Loading

Closes #

Verification Steps

  1. Have a working and registerd cluster with a kafka rhoas dedicated register-cluster
  2. Run deregister rhoas dedicated deregister-cluster
  3. All kafkas should delete first then deregistered from kfm then removing addons

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

dimakis
dimakis reviewed Feb 21, 2023
View reviewed changes
pkg/cmd/dedicated/deregister/deregister.go Outdated Show resolved Hide resolved
pkg/cmd/dedicated/deregister/deregister.go Outdated Show resolved Hide resolved
pkg/cmd/dedicated/deregister/deregister.go Outdated Show resolved Hide resolved
pkg/cmd/dedicated/deregister/deregister.go Outdated Show resolved Hide resolved
@jackdelahunt jackdelahunt requested a review from dimakis February 28, 2023 10:33
@jackdelahunt jackdelahunt force-pushed the deregister branch 4 times, most recently from 4d4176d to a1e0ff5 Compare March 3, 2023 10:17
@jackdelahunt jackdelahunt force-pushed the deregister branch 2 times, most recently from 0f086de to 765db51 Compare March 3, 2023 10:35
dimakis
dimakis reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of thoughts and comments

pkg/cmd/dedicated/deregister/deregister.go Outdated Show resolved Hide resolved
pkg/cmd/dedicated/deregister/deregister.go Show resolved Hide resolved
pkg/cmd/dedicated/deregister/deregister.go Outdated Show resolved Hide resolved
pkg/cmd/dedicated/deregister/deregister.go Outdated Show resolved Hide resolved
pkg/cmd/dedicated/deregister/deregister.go Show resolved Hide resolved
@jackdelahunt jackdelahunt force-pushed the deregister branch 3 times, most recently from df321ab to 0d9a0d7 Compare March 6, 2023 13:58
dimakis and others added 19 commits March 7, 2023 14:20
@dimakis @jackdelahunt
refactor: refactoring dedicated list to use refactored search string …
e983007 
…func
@dimakis @jackdelahunt
refactor: refactor and addition of name + id of cluster in prompt
4724857
@dimakis @jackdelahunt
refactor: refactor to functional create enterprise flow with some upd…
c1ba5a8 
…ates based on reviews
@dimakis @jackdelahunt
Add machine pool logic (#1795)
38ca4ea 
* feat: addition of the new dedicated command to select ocm cluster

* feat: addition of getting machine pools and hitting the register cluster endpoint in KFM

* refactor: addition of close ocm connection

* fix: addition of autoscaling check logic

* refactor: addresses commments made in PR

* refactor: addresses comments in review

* feat: addition of the addon installation flow

* feat: addition of cluster-id flag

* refactor: addresses some further comments in the review

* feat: addition of localization

* refactor: addition of error when user has no valid clusters
@rkpattnaik780 @jackdelahunt
chore(vendor): update vendoring (#1798)
10f3ad2
@dimakis @jackdelahunt
Add cluster id to create kafka (#1804)
69e4e56 
* feat: addition of descriptions and examples to dedicated

* feat: Allows the CLI to install stage env addons when terraforming customer-cloud dataplane clusters

* refactor: the default api url is now set when creating a connection instead of in the registercluster cmd file

* refactor: update some func and var names

* refactor: add cluster-id flag to create kafka cmd to allow kafka creation on CC cluster

* refactor: doc and small refactor
@dimakis @jackdelahunt
refactor: Refactor ocm methods out of register cmd file (#1807)
293854b 
* feat: addition of descriptions and examples to dedicated

* feat: Allows the CLI to install stage env addons when terraforming customer-cloud dataplane clusters

* refactor: extraction of clustermgmt funcs from register to own dir

* refactor: addresses cluster pagination and refactor of ocm functions
@jackdelahunt
feat: added deregister command
936b10b
@jackdelahunt
refactor: imrpoved quality of deregister command
06176c8
@jackdelahunt
chore: added localisation to deregister command
5878483
@jackdelahunt
feat: deregister now waits for all kafkas to be deleted
bc3b700
@jackdelahunt
fix: better logging when deleting kafka
7a0e46a
@jackdelahunt
refactor: getting cluster list now ask kfm then ocm
60026a9
@jackdelahunt
chore: remove unused fields
a4e0665
@jackdelahunt
fix: edge case handling in deregister
3acb2de
@dimakis @jackdelahunt
docs: update the docs (#1826)
7d6f738
@dimakis @jackdelahunt
refactor: print the httpresponse (#1827)
46bd090
@jackdelahunt
fix: fixing broken lints
b89031b
@jackdelahunt
chore: rebase changes
9a6f27c
@dimakis dimakis merged commit 24ee8a6 into dedicated Mar 8, 2023
@dimakis dimakis deleted the deregister branch March 8, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 left review comments

@dimakis dimakis dimakis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackdelahunt @machi1990 @dimakis @rkpattnaik780