Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] turn on debug mode for all commands #346

Closed
craicoverflow opened this issue Feb 16, 2021 · 5 comments
Closed

[Idea] turn on debug mode for all commands #346

craicoverflow opened this issue Feb 16, 2021 · 5 comments

Comments

@craicoverflow
Copy link
Contributor

craicoverflow commented Feb 16, 2021

It would be quite nice to be able to persist debug mode without having to pass --debug all the time.

This could be in the form of a new config command:

$ rhoas config set debug true
Debug mode is now enabled for all commands..
@wtrocki
Copy link
Collaborator

wtrocki commented Jul 1, 2021

Working on this as we agreed that we cannot release CLi with current implementation.

@wtrocki
Copy link
Collaborator

wtrocki commented Jul 5, 2021

@craicoverflow all are set debug true an positional characters?

@craicoverflow
Copy link
Contributor Author

Yes in that example, but maybe there is a better way without so many sub-commands?

rhoas config set-debug true

As an example. Not sure if this is the best way.

@wtrocki
Copy link
Collaborator

wtrocki commented Jul 5, 2021

So I'm happy eather way.

Do you feel that this command should enable editing any value of the config or we should support some well known use cases?

My take is that it will be easier to have multiple subcomands like set-debug etc. that handle specific cases. Handling generic config makes less sense as we might just open config and make edits there.

@craicoverflow
Copy link
Contributor Author

I think we should definitely only enable specific cases and not let this give the user the ability to modify anything. Let's only enable editing the debug mode for now.

@wtrocki wtrocki closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants