feat: add dev preview capability #668
Conversation
|
|
||
| logger, err := f.Logger() | ||
| if err != nil { | ||
| logger.Info("Cannot enable dev preview") |
There was a problem hiding this comment.
I will do i18n as last step on the feature branch. Ignore non externalized strings for now
pkg/cmd/root/root.go
Outdated
| @@ -46,17 +46,25 @@ func NewRootCommand(f *factory.Factory, version string) *cobra.Command { | |||
| var help bool | |||
| fs.BoolVarP(&help, "help", "h", false, f.Localizer.MustLocalize("root.cmd.flag.help.description")) | |||
|
|
|||
| var devpreview *string = nil | |||
| cmd.Flags().StringVar(devpreview, "devpreview", "", f.Localizer.MustLocalize("root.cmd.flag.devpreview.description")) | |||
There was a problem hiding this comment.
I spent most of the time thinking how to enable this properly.
Choose string finally as the best way.
Technically we can validate it for the proper values as well :)
This is as string because:
- boolean has only 2 possible values - we need 3
- It will simplify adding tiers later without introducing other flags etc.
There was a problem hiding this comment.
What will the valid values be?
There was a problem hiding this comment.
Open to your feedback.
Currently true, yes etc. but we can rename flag and have alpha beta etc.
There was a problem hiding this comment.
https://github.com/spf13/cobra#persistent-flags
This should use persistent flags.
There was a problem hiding this comment.
The thing about string flags is the need an argument so you cannot just do rhoas srs --devpreview - its a bit more awkward to achieve.
There was a problem hiding this comment.
Acording to this issue boolean ones are not going to help us
This command doesn't way as presented. Srs will not be visible. DevPreview flag on it's own modifies config so its not needed when calling dev preview commands.
rhoas srs --devpreview -> rhoas --devpreview=true
--devpreview in this sense provides empty string and means nothing.
If there is way to recognize flag being passed that will be good
| cmd.AddCommand(serviceaccount.NewServiceAccountCommand(f)) | ||
| cmd.AddCommand(cluster.NewClusterCommand(f)) | ||
| cmd.AddCommand(status.NewStatusCommand(f)) | ||
| cmd.AddCommand(completion.NewCompletionCommand(f)) | ||
| cmd.AddCommand(whoami.NewWhoAmICmd(f)) | ||
| cmd.AddCommand(cliversion.NewVersionCmd(f)) | ||
|
|
||
| // Dev preview commands | ||
| if profile.DevPreviewEnabled(f) { |
There was a problem hiding this comment.
I have investigated using custom help message template based on the annotations, however that will require pulling some large parts of the internal cobra functions etc. so decided to simplify it by listing those commands bellow. This will be mostly seen by us so there is no big deal with it.
|
|
||
| logger, err := f.Logger() | ||
| if err != nil { | ||
| logger.Info("Cannot enable dev preview") |
There was a problem hiding this comment.
That will fail because the logger is not created.
| cmd.AddCommand(serviceaccount.NewServiceAccountCommand(f)) | ||
| cmd.AddCommand(cluster.NewClusterCommand(f)) | ||
| cmd.AddCommand(status.NewStatusCommand(f)) | ||
| cmd.AddCommand(completion.NewCompletionCommand(f)) | ||
| cmd.AddCommand(whoami.NewWhoAmICmd(f)) | ||
| cmd.AddCommand(cliversion.NewVersionCmd(f)) | ||
|
|
||
| // Dev preview commands | ||
| if profile.DevPreviewEnabled(f) { | ||
| cmd.AddCommand(registry.NewServiceRegistryCommand(f)) |
There was a problem hiding this comment.
❯ ./rhoas --devpreview=yes registry
Error: unknown command "registry" for "rhoas"How do I get this to work?
…ation was enabled)
|
Update from call. We will refactor this command post POC like in the #346 , however for the moment, I will keep flags this way. Pushing changes to feature branch. |
|
This is still printing help when dev preview is enabled. |
Creating as separate PR to review but this PR targets srs-cli branch that has SDK and initial commands.
Usage:
Check if commands are there