Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide feature flags to enable specific plugins #72

Closed
namit-chandwani opened this issue Jun 18, 2021 · 4 comments
Closed

Provide feature flags to enable specific plugins #72

namit-chandwani opened this issue Jun 18, 2021 · 4 comments
Assignees
@namit-chandwani
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@namit-chandwani
Copy link
Member

namit-chandwani commented Jun 18, 2021 •
edited
Loading

Generally, feature flags allow us to activate or deactivate specific features of our application.
In our case, we'll be allowing the SDK users to use feature flags to activate certain plugins.

This requires further investigation and discussion before starting out.
@namit-chandwani namit-chandwani added the enhancement New feature or request label Jun 18, 2021
@wtrocki
Copy link
Contributor

wtrocki commented Jun 18, 2021

In rhoas we have something like this:

Flags:
  --dev-preview-commands     Enable dev preview commands

@namit-chandwani namit-chandwani self-assigned this Jun 20, 2021
@namit-chandwani namit-chandwani mentioned this issue Jun 26, 2021
Closed
6 tasks
@ankithans ankithans mentioned this issue Jun 30, 2021
Closed
@wtrocki wtrocki added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 2, 2021
@wtrocki
Copy link
Contributor

wtrocki commented Jul 2, 2021

It will be most likely copy paste/inspired by: redhat-developer/app-services-cli#346

@wtrocki wtrocki closed this as completed Aug 9, 2021
@namit-chandwani
Copy link
Member Author

@wtrocki Have we completely scrapped this feature or is this just out of scope for now?

@wtrocki
Copy link
Contributor

wtrocki commented Aug 9, 2021

We going to implement that by environment variable and it will be simple check
This was controversial from beginning :D

@wtrocki wtrocki reopened this Aug 9, 2021
@wtrocki wtrocki closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namit-chandwani namit-chandwani

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add dev preview feature aerogear/charmil
2 participants
@wtrocki @namit-chandwani