fix: add validation for search input

pkg/cmd/kafka/consumergroup/list/list.go

@@ -13,6 +13,8 @@ import (
 	"github.com/redhat-developer/app-services-cli/pkg/cmd/flag"
 	"github.com/redhat-developer/app-services-cli/pkg/cmdutil"
 	flagutil "github.com/redhat-developer/app-services-cli/pkg/cmdutil/flags"
+	consumergrouputil "github.com/redhat-developer/app-services-cli/pkg/kafka/consumergroup"
+
 	"github.com/redhat-developer/app-services-cli/pkg/connection"
 	"github.com/redhat-developer/app-services-cli/pkg/dump"
 	"github.com/redhat-developer/app-services-cli/pkg/iostreams"
@@ -73,6 +75,15 @@ func NewListConsumerGroupCommand(f *factory.Factory) *cobra.Command {
 				return fmt.Errorf(opts.localizer.MustLocalize("kafka.consumerGroup.common.error.noKafkaSelected"))
 			}
 
+			if opts.search != "" {
+				validator := &consumergrouputil.Validator{
+					Localizer: opts.localizer,
+				}
+				if err = validator.ValidateSearchInput(opts.search); err != nil {
+					return err
+				}
+			}
+
 			opts.kafkaID = cfg.Services.Kafka.ClusterID
 
 			return runList(opts)

pkg/kafka/consumergroup/validators.go

@@ -0,0 +1,33 @@
+package consumergroup
+
+import (
+	"errors"
+	"regexp"
+
+	"github.com/redhat-developer/app-services-cli/pkg/common/commonerr"
+	"github.com/redhat-developer/app-services-cli/pkg/localize"
+)
+
+const (
+	legalSearchChars = "^[a-zA-Z0-9-]+$"
+)
+
+// Validator is a type for validating Kafka consumer group configuration values
+type Validator struct {
+	Localizer localize.Localizer
+}
+
+func (v *Validator) ValidateSearchInput(val interface{}) error {
+	search, ok := val.(string)
+	if !ok {
+		return commonerr.NewCastError(val, "string")
+	}
+
+	matched, _ := regexp.Match(legalSearchChars, []byte(search))
+
+	if matched {
+		return nil
+	}
+
+	return errors.New(v.Localizer.MustLocalize("kafka.consumerGroup.list.error.illegalSearchValue", localize.NewEntry("Search", search)))
+}

pkg/localize/locales/en/cmd/kafka_consumergroup_common.en.toml

@@ -31,4 +31,8 @@ one = 'no Kafka instance is currently selected, run "rhoas kafka use" to set the
 one = 'you are unauthorized to {{.Operation}} these consumer groups'
 
 [kafka.consumerGroup.list.error.forbidden]
-one = 'you are forbidden to {{.Operation}} these consumer groups'
+one = 'you are forbidden to {{.Operation}} these consumer groups'
+
+[kafka.consumerGroup.list.error.illegalSearchValue]
+description = 'Error message when invalid chars are used for search flag'
+one = 'illegal search value "{{.Search}}"; only letters (Aa-Zz), numbers and "-" are accepted'