feat(consumer-group list): add search flag

redhat-developer · Jul 9, 2021 · afda40f · afda40f
1 parent cd8ffbc
commit afda40f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/docs/commands/rhoas_kafka_consumer-group_list.adoc b/docs/commands/rhoas_kafka_consumer-group_list.adoc
diff --git a/pkg/cmd/kafka/consumergroup/list/list.go b/pkg/cmd/kafka/consumergroup/list/list.go
@@ -34,6 +34,7 @@ type Options struct {
 	kafkaID string
 	limit   int32
 	topic   string
+	search  string
 }
 
 type consumerGroupRow struct {
@@ -81,6 +82,7 @@ func NewListConsumerGroupCommand(f *factory.Factory) *cobra.Command {
 	cmd.Flags().Int32VarP(&opts.limit, "limit", "", 1000, opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.limit"))
 	cmd.Flags().StringVarP(&opts.output, "output", "o", "", opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.output.description"))
 	cmd.Flags().StringVar(&opts.topic, "topic", "", opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.topic.description"))
+	cmd.Flags().StringVar(&opts.search, "search", "", opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.search"))
 
 	_ = cmd.RegisterFlagCompletionFunc("topic", func(cmd *cobra.Command, _ []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 		return cmdutil.FilterValidTopicNameArgs(f, toComplete)
@@ -91,6 +93,7 @@ func NewListConsumerGroupCommand(f *factory.Factory) *cobra.Command {
 	return cmd
 }
 
+// nolint:funlen
 func runList(opts *Options) (err error) {
 	conn, err := opts.Connection(connection.DefaultConfigRequireMasAuth)
 	if err != nil {
@@ -114,6 +117,10 @@ func runList(opts *Options) (err error) {
 	if opts.topic != "" {
 		req = req.Topic(opts.topic)
 	}
+	if opts.search != "" {
+		req = req.GroupIdFilter(opts.search)
+	}
+
 	consumerGroupData, httpRes, err := req.Execute()
 	if err != nil {
 		if httpRes == nil {

diff --git a/pkg/localize/locales/en/cmd/kafka_consumergroup_list.en.toml b/pkg/localize/locales/en/cmd/kafka_consumergroup_list.en.toml
@@ -21,6 +21,10 @@ $ rhoas kafka consumer-group list -o json
 description = 'Description for the --limit flag'
 one = 'The maximum number of consumer groups to be returned'
 
+[kafka.consumerGroup.list.flag.search]
+description = 'Description for the --search flag'
+one = 'Text search to filter consumer groups by ID'
+
 [kafka.consumerGroup.list.log.info.noConsumerGroups]
 one = 'Kafka instance "{{.InstanceName}}" has no consumer groups'