Change lookup to query to ensure list #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're still testing this further. We ran into some issues, but are not yet sure if they're related to this. |
|
So, I've investigated the issue a bit more. Due to the last return statement ( With the currently added 2 commits, this issue should be resolved. And in my opinion this is ready to be merged once approved :) |
Rickmarges
force-pushed
the
patch/change_to_query
branch
from
5ead506 to
fe391ef
Compare
Rickmarges
force-pushed
the
patch/change_to_query
branch
from
fe391ef to
b01ea27
Compare
ivarmu
added
bug
sean-m-sullivan
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
@ivarmu this looks good, looks like we need a changelog though as this is a breaking change, as well as the present/compare list bugfix,
sean-m-sullivan
requested changes
Jul 16, 2023
sean-m-sullivan
approved these changes
Jul 17, 2023
ivarmu
added a commit
to automationiberia/infra.aap_configuration
that referenced
this pull request
Jul 31, 2023
sean-m-sullivan
pushed a commit
that referenced
this pull request
Aug 3, 2023
* added singulars to be treated as well * new attributes for roles * new attributes for roles * added changelog fragment * fix on map_item function * removed extra empty line * fixes on object_diff inputs * removed debug information. added ORGANIZATIONLESS to credentials and users without an organization * fix lintering issues * fix lintering issues * fix lintering issues * tests fixes. multiple list from #647 fixed. Test ping URL fixed
djdanielsson
pushed a commit
to redhat-cop/aap_configuration_extended
that referenced
this pull request
Oct 5, 2024
* added singulars to be treated as well * new attributes for roles * new attributes for roles * added changelog fragment * fix on map_item function * removed extra empty line * fixes on object_diff inputs * removed debug information. added ORGANIZATIONLESS to credentials and users without an organization * fix lintering issues * fix lintering issues * fix lintering issues * tests fixes. multiple list from redhat-cop/infra.aap_configuration#647 fixed. Test ping URL fixed
djdanielsson
pushed a commit
to redhat-cop/aap_configuration_extended
that referenced
this pull request
Oct 5, 2024
* added singulars to be treated as well * new attributes for roles * new attributes for roles * added changelog fragment * fix on map_item function * removed extra empty line * fixes on object_diff inputs * removed debug information. added ORGANIZATIONLESS to credentials and users without an organization * fix lintering issues * fix lintering issues * fix lintering issues * tests fixes. multiple list from redhat-cop/infra.aap_configuration#647 fixed. Test ping URL fixed
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* Change lookup to query to ensure list * Prevent the diff plugin from returning a nested list * Correctly make use of the present_list * Add changelog fragment --------- Co-authored-by: Marges, RSY (Rick) <[email protected]> Co-authored-by: Ivan Aragonés Muniesa <[email protected]>
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* Change lookup to query to ensure list * Prevent the diff plugin from returning a nested list * Correctly make use of the present_list * Add changelog fragment --------- Co-authored-by: Marges, RSY (Rick) <[email protected]> Co-authored-by: Ivan Aragonés Muniesa <[email protected]>
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* added singulars to be treated as well * new attributes for roles * new attributes for roles * added changelog fragment * fix on map_item function * removed extra empty line * fixes on object_diff inputs * removed debug information. added ORGANIZATIONLESS to credentials and users without an organization * fix lintering issues * fix lintering issues * fix lintering issues * tests fixes. multiple list from redhat-cop#647 fixed. Test ping URL fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When first configuring an organization with only 1 inventory defined, the configuration fails with the message:
argument 'controller_inventories' is of type <class 'dict'> and we were unable to convert to listThe diff_role tasks use the
lookupplugin to calculate the differences, which doesn't necessarily create a list when it recieves one item. This change will move fromlookuptoquery, which will always return a list (see relevant link for more info)How should this be tested?
with_present: trueOther Relevant info, PRs, etc
https://docs.ansible.com/ansible/latest/plugins/lookup.html#forcing-lookups-to-return-lists-query-and-wantlist-true