Solve issue Object diff for roles removing most roles
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarmu
changed the title
Object diff for roles removing most roles
|
Pending for some extra info asked at the issue #552 . |
…users without an organization
ivarmu
changed the title
Object diff for roles removing most rolesObject diff for roles removing most roles
|
So was this a bug where if we add spaces to that are that it removes. And is this a WIP as it says still not tested? |
|
The spaces additions/removals are basically sthetic and/or required by the lintering checkings. I checked manually all the changes and also run locally all the tests in I've also improved the |
sean-m-sullivan
approved these changes
Aug 3, 2023
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* added singulars to be treated as well * new attributes for roles * new attributes for roles * added changelog fragment * fix on map_item function * removed extra empty line * fixes on object_diff inputs * removed debug information. added ORGANIZATIONLESS to credentials and users without an organization * fix lintering issues * fix lintering issues * fix lintering issues * tests fixes. multiple list from redhat-cop#647 fixed. Test ping URL fixed
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* added singulars to be treated as well * new attributes for roles * new attributes for roles * added changelog fragment * fix on map_item function * removed extra empty line * fixes on object_diff inputs * removed debug information. added ORGANIZATIONLESS to credentials and users without an organization * fix lintering issues * fix lintering issues * fix lintering issues * tests fixes. multiple list from redhat-cop#647 fixed. Test ping URL fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tries to solve issue #552:
How should this be tested?
Manually tested. Automatic tests also passed.
Is there a relevant Issue open for this?
resolves #552
Other Relevant info, PRs, etc
N/A