Merge runAsUser and runAsNonRoot checks in a single testcase/check. #2654
+44
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two test cases have been merged: access-control-security-context-run-as-non-root-user-check access-control-security-context-non-root-user-id-check As a result, both securityConstraint fields "runAsNonRoot" and "runAsUser" are checked inside the existing test case access-control-security-context-run-as-non-root-user-check To pass the test case, either: a) runAsUser must be `!= 0` at pod or container level. b) runAsNonRoot must be `true` at pod or container level.
…pected_results.yaml file.
|
from change #2654: |
greyerof
added a commit
to redhat-best-practices-for-k8s/certsuite-qe
that referenced
this pull request
Dec 20, 2024
Due to this certsuite PR: redhat-best-practices-for-k8s/certsuite#2654 , the runAsUser and runAsNonRoot securityContext fields check has been merged into access-control-security-context-run-as-non-root-user-check.
|
from change #2654: |
QE PR redhat-best-practices-for-k8s/certsuite-qe#1034 is pending to merge but the branch can be used here.
|
from change #2654: |
|
from change #2654: |
edcdavid
approved these changes
Dec 20, 2024
bnshr
approved these changes
Dec 23, 2024
bnshr
merged commit 8b19539
into
redhat-best-practices-for-k8s:main
35 of 36 checks passed
|
from change #2654: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two test cases have been merged:
As a result, both securityConstraint fields "runAsNonRoot" and "runAsUser" are checked now inside the existing test case
access-control-security-context-non-root-user-id-checkTo pass the test case, either:
a) runAsUser must be
!= 0at pod or container level.b) runAsNonRoot must be
trueat pod or container level.