Rename access control test #1034
Closed
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to this certsuite PR: redhat-best-practices-for-k8s/certsuite#2654 , the runAsUser and runAsNonRoot securityContext fields check has been merged into access-control-security-context-run-as-non-root-user-check.
greyerof
added a commit
to greyerof/certsuite
that referenced
this pull request
Dec 20, 2024
QE PR redhat-best-practices-for-k8s/certsuite-qe#1034 is pending to merge but the branch can be used here.
|
I'll rework the certsuite PR to use the other tc name so we don't need to change this repo. |
bnshr
pushed a commit
to redhat-best-practices-for-k8s/certsuite
that referenced
this pull request
Dec 23, 2024
…2654) * Merge runAsUser and runAsNonRoot checks in a single testcase/check. These two test cases have been merged: access-control-security-context-run-as-non-root-user-check access-control-security-context-non-root-user-id-check As a result, both securityConstraint fields "runAsNonRoot" and "runAsUser" are checked inside the existing test case access-control-security-context-run-as-non-root-user-check To pass the test case, either: a) runAsUser must be `!= 0` at pod or container level. b) runAsNonRoot must be `true` at pod or container level. * Remove access-control-security-context-non-root-user-id-check from expected_results.yaml file. * QE branch ref set to rename_access_control_test QE PR redhat-best-practices-for-k8s/certsuite-qe#1034 is pending to merge but the branch can be used here. * Use access-control-security-context-non-root-user-id-check. * Update expected_results.yaml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to this certsuite PR:
redhat-best-practices-for-k8s/certsuite#2654 ,
the runAsUser and runAsNonRoot securityContext fields check has been
merged into access-control-security-context-run-as-non-root-user-check.