modified rhtap installation to accept the installation options generated by pict #366
Conversation
xinredhat
force-pushed
the
pict_installation
branch
from
852c948 to
ffe21bc
Compare
xinredhat
force-pushed
the
pict_installation
branch
2 times, most recently
from
c10e6c1 to
0685437
Compare
xinredhat
changed the title
xinredhat
force-pushed
the
pict_installation
branch
from
0685437 to
fcb3c26
Compare
|
/retest |
|
The both sub-pipelineruns of pr-e2e-tests-5s68f Succeeded, I think we can merge this PR. @prietyc123 WDYT? |
xinredhat
force-pushed
the
pict_installation
branch
from
fcb3c26 to
868fce2
Compare
| - name: tpa_config | ||
| type: string | ||
| description: "The TPA option for rhtap-cli installation. Valid values are 'new' and 'hosted'." | ||
| - name: registry_config |
There was a problem hiding this comment.
Should we consider any default value? Same question for other params as well
There was a problem hiding this comment.
I would like to add a default.pict in repository to specify the default values. For example PR#203 So the modification of install.sh won't break the expected result. If we need to consider any default value in task or pipline yaml files in the future we can set default values.
makes sense merging it. However I have added few small comments. Could you please take a look |
xinredhat
force-pushed
the
pict_installation
branch
from
868fce2 to
03a6554
Compare
|
/approve |
xinredhat
force-pushed
the
pict_installation
branch
from
03a6554 to
a2e04c3
Compare
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prietyc123, xinredhat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
modified rhtap installation to accept the installation options generated by pict