added default.pict to define rhtap installation when running rhtap-e2e ci #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhopp
reviewed
Jan 9, 2025
| # SCM: valid values: github, gitlab, bitbucket | ||
| # Pipeline: valid values: github, gitlab, bitbucket | ||
|
|
||
| OCP: 4.17 |
There was a problem hiding this comment.
https://github.com/redhat-appstudio/rhtap-cli/pull/366/files Has also Auth. Is it not required or is it missing?
(It's also missing in the commented section documenting possible values (in rhtap-cli as well)
There was a problem hiding this comment.
It's missing, Auth is added.
xinredhat
force-pushed
the
pict_install
branch
from
65e519b to
aaf1fd1
Compare
xinredhat
force-pushed
the
pict_install
branch
from
aaf1fd1 to
8f7b6fe
Compare
|
|
/retest |
|
@xinredhat: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.17-kzj6zTest results analysis<not enabled> |
rhopp
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to define rhtap installation by adding default.pict , which depends on redhat-appstudio/rhtap-cli#366 and redhat-appstudio/rhtap-cli#371