Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Contentful image loading #593

Merged
merged 14 commits into from
Jul 19, 2018
Merged
Prev Previous commit
Next Next commit
Add test for getting image details with dimensions
Lily Hoskin authored and Lily Hoskin committed Jul 9, 2018
commit 1df2b1806e2a46d690f1427773c3054301237438
19 changes: 19 additions & 0 deletions src/data/image.test.js
Original file line number Diff line number Diff line change
@@ -17,6 +17,25 @@ describe("image", () => {

expect(getter(imageDetails.id)).toEqual(imageDetails);
});

it("returns the correct imageDetails when dimensions are provided", () => {
const imageDetails: ImageDetails = sampleOne(generateImageDetails);
const imageDimensions = { width: 500, height: 200 };
const imageDetailsWithDimensions = {
...imageDetails,
uri: `${imageDetails.uri}?w=${imageDimensions.width}&h=${
imageDimensions.height
}&fit=fill`
};

const getter = getImageDetails({
[imageDetails.id]: imageDetails
});

expect(getter(imageDetails.id, imageDimensions)).toEqual(
imageDetailsWithDimensions
);
});
});

describe("decodeImageDetails", () => {