Code

Optimize Contentful image loading#593

Code

Merged

Lily418 merged 14 commits intomasterredbadger/pride-london-app:masterfrom gh-587-contentful-image-loading-resizeredbadger/pride-london-app:gh-587-contentful-image-loading-resizeCopy head branch name to clipboardJul 19, 2018

+125-13

Commits

Commits on Jul 6, 2018

• Add option to provide desired dimensions to getImageDetails, work in progress implementation of ImageBackground that uses static values

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  a699dc7

  Copy full SHA for a699dc7

Commits on Jul 9, 2018

• Add loading of specific size of image

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  776f780

  Copy full SHA for 776f780

• Make placeholder image used for measuring transparent

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  2e203f6

  Copy full SHA for 2e203f6

• Tidy ImageBackground.js code

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  f3cf9a4

  Copy full SHA for f3cf9a4

• Merge branch 'master' into gh-587-contentful-image-loading-resize

  

  Lily

  authored
  5e52038

  Copy full SHA for 5e52038

• Update tests for ImageBackground to cover placeholder image and update test for image rendering

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  586699e

  Copy full SHA for 586699e

• Add test for getting image details with dimensions

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  1df2b18

  Copy full SHA for 1df2b18

• Remove unnecessary else from data/image.js

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  17982cf

  Copy full SHA for 17982cf

• Remove use on bind in ImageBackground

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  643dbb6

  Copy full SHA for 643dbb6

Commits on Jul 16, 2018

• Update flow types for ImageBackground and image data

  

  Lily Hoskin

  authored and

  Lily Hoskin

  committed
  5d5a776

  Copy full SHA for 5d5a776

Commits on Jul 19, 2018

• Use LayoutEvent rather than generic object for layout event

  

  Lily Hoskin

  committed
  2c3a15d

  Copy full SHA for 2c3a15d

• Add test for undefined image with dimensions

  

  Lily Hoskin

  committed
  aa848fe

  Copy full SHA for aa848fe

• Reorganise imports in ImageBackground.js

  

  Lily Hoskin

  committed
  778ae72

  Copy full SHA for 778ae72

• Handle case that image details is undefined but dimensions are provided

  

  Lily Hoskin

  committed
  d21a48c

  Copy full SHA for d21a48c