Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2255501: [release-4.15] supply client operator version while onboarding #58

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Jan 8, 2024

manual cherry-pick of #49 and #46 combined. the difference is this PR tracks the ocs-operator release-4.15 branch as a dependency rather than main

- provider server makes it mandatory to  supply client operator version
for successful onboarding

Signed-off-by: Leela Venkaiah G <[email protected]>
Copy link

openshift-ci bot commented Jan 8, 2024

@leelavg: This pull request references Bugzilla bug 2255501, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2255501: [release-4.15] supply client operator version while onboarding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Jan 8, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@leelavg: This pull request references Bugzilla bug 2255501, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2255501: [release-4.15] supply client operator version while onboarding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@nb-ohad
Copy link
Contributor

nb-ohad commented Jan 8, 2024

/lgtm

Copy link

openshift-ci bot commented Jan 8, 2024

@agarwal-mudit: This pull request references Bugzilla bug 2255501, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Jan 8, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@agarwal-mudit: This pull request references Bugzilla bug 2255501, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/approve

Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: agarwal-mudit, leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 80ead20 into red-hat-storage:release-4.15 Jan 8, 2024
14 checks passed
Copy link

openshift-ci bot commented Jan 8, 2024

@leelavg: All pull requests linked via external trackers have merged:

Bugzilla bug 2255501 has been moved to the MODIFIED state.

In response to this:

Bug 2255501: [release-4.15] supply client operator version while onboarding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leelavg leelavg deleted the r-46 branch March 8, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants