-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supply client operator version while onboarding #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
leelavg
force-pushed
the
5072-onboard
branch
from
December 12, 2023 06:10
e9b1537
to
e57b655
Compare
This was referenced Dec 18, 2023
Closed
leelavg
force-pushed
the
5072-onboard
branch
from
December 20, 2023 10:12
e57b655
to
b896b2e
Compare
leelavg
changed the title
[RHSTOR-5072]: supply client operator version while onboarding
supply client operator version while onboarding
Dec 20, 2023
leelavg
force-pushed
the
5072-onboard
branch
from
December 21, 2023 10:01
b896b2e
to
276eec0
Compare
leelavg
commented
Dec 21, 2023
LGTM |
- provider server makes it mandatory to supply client operator version for successful onboarding Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg
force-pushed
the
5072-onboard
branch
from
December 21, 2023 11:22
276eec0
to
d26b8ef
Compare
leelavg
requested review from
nb-ohad
and removed request for
jarrpa and
Madhu-1
December 21, 2023 11:22
nb-ohad
approved these changes
Dec 21, 2023
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leelavg, nb-ohad The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provider server makes it mandatory to supply client operator version for successful onboarding and so we'll send the client operator version as part of onboarding process
[RHSTOR-5072]
depends on: red-hat-storage/ocs-operator#2308