Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supply client operator version while onboarding #46

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 11, 2023

provider server makes it mandatory to supply client operator version for successful onboarding and so we'll send the client operator version as part of onboarding process

[RHSTOR-5072]
depends on: red-hat-storage/ocs-operator#2308

@leelavg
Copy link
Contributor Author

leelavg commented Dec 11, 2023

  • tested locally, client should provide operator version additionally for successful onboarding

@leelavg leelavg requested review from Madhu-1 and jarrpa December 11, 2023 11:25
@df-build-team df-build-team requested a review from a team December 11, 2023 11:48
@leelavg leelavg marked this pull request as draft December 12, 2023 09:57
@leelavg leelavg changed the title [RHSTOR-5072]: supply client operator version while onboarding supply client operator version while onboarding Dec 20, 2023
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 21, 2023
go.mod Outdated Show resolved Hide resolved
@nb-ohad
Copy link
Contributor

nb-ohad commented Dec 21, 2023

LGTM

- provider server makes it mandatory to  supply client operator version
for successful onboarding

Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg leelavg marked this pull request as ready for review December 21, 2023 11:22
@leelavg leelavg requested review from nb-ohad and removed request for jarrpa and Madhu-1 December 21, 2023 11:22
Copy link

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nb-ohad nb-ohad merged commit 32bce3b into red-hat-storage:main Dec 21, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants