Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #781 Book a viewing #931

Merged
merged 7 commits into from
Apr 20, 2020
Merged

feat: #781 Book a viewing #931

merged 7 commits into from
Apr 20, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented Apr 16, 2020

No description provided.

willmcvay
willmcvay requested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some work to expand the theme a bit but nice work overall 👍

packages/web-components/src/viewing-booking/client/components/viewing-booking.svelte Outdated
}
.viewing-booking-form-submit button:hover {
cursor: pointer;
background: #00a7e3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few colors in this file - can you use the theme for these please? If you look at search widget button there are primary and secondary accent colors for button color / background and inverse for hover if that makes sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I applied theme classes to this PR, pls check it again

@ant066 ant066 marked this pull request as ready for review April 17, 2020 04:25
@ant066 ant066 changed the title [WIP] feat: #781 Book a viewing feat: #781 Book a viewing Apr 17, 2020
duong-se
duong-se reviewed Apr 17, 2020
View reviewed changes
packages/web-components/src/common/components/modal.svelte Outdated
width: auto !important;
height: auto !important;
transform: translate(-50%, -50%);
border-radius: 4px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use rem instead of em.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updated

duong-se
duong-se reviewed Apr 17, 2020
View reviewed changes
packages/web-components/src/common/components/modal.svelte Outdated
@@ -17,12 +18,78 @@
background: #00000052;
z-index: 1;
}
@media only screen and (min-width: 48em) {
.reapit-modal-wrapper .reapit-modal {
top: 50% !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls avoid to use !important because it's very hard to debug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updated

duong-se
duong-se reviewed Apr 17, 2020
View reviewed changes
packages/web-components/src/common/components/modal.svelte Outdated
top: 50% !important;
left: 50% !important;
width: auto !important;
height: auto !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls avoid to use !important because it's very hard to debug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updated

duong-se
duong-se reviewed Apr 17, 2020
View reviewed changes
packages/web-components/src/common/components/modal.svelte Outdated
margin: 0;
text-align: center;
font-size: 1em;
padding: 1em 50px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use em instead of px

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updated

duong-se
duong-se reviewed Apr 17, 2020
View reviewed changes
packages/web-components/src/viewing-booking/client/components/viewing-booking.svelte Outdated
.viewing-booking-email-form p {
padding: 0.5em 0;
line-height: 1em;
margin-bottom: 0.5em !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls avoid to use important

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updated

duong-se
duong-se reviewed Apr 17, 2020
View reviewed changes
packages/web-components/src/viewing-booking/client/components/viewing-booking.svelte Outdated
padding: 0.3em;
border-radius: 3px;
cursor: pointer;
border: 1px solid !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls avoid to use important

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updated

@github-actions github-actions bot requested a review from duong-se April 17, 2020 08:27
willmcvay
willmcvay approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

duong-se
duong-se approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ant066 ant066 merged commit c6ccb5d into master Apr 20, 2020
@ant066 ant066 deleted the book-a-viewing branch April 20, 2020 03:09
@ant066 ant066 restored the book-a-viewing branch April 20, 2020 04:14
ant066 added a commit that referenced this pull request Apr 20, 2020
@ant066
Revert "feat: #781 Book a viewing (#931)"
87c95e6 
This reverts commit c6ccb5d.
willmcvay pushed a commit that referenced this pull request Apr 29, 2020
@ant066 @andt-dwarvesv
feat: #781 Book a viewing (#931)
629fb15 
* feat: #781 I want to click button to arrange a viewing with Estate Agent

* chore: #781 update style

* chore: add some test

* chore: #781 update theme class

* chore: #781 update styles

Co-authored-by: andt <[email protected]>
@duong-se duong-se mentioned this pull request Jun 18, 2020
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se approved these changes

@willmcvay willmcvay willmcvay approved these changes

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

Assignees

@ant066 ant066

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ant066 @willmcvay @duong-se @andt-dwarvesv