Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1748 remove unuse dependencies and add use dependencies to package.json #1775

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

duong-se
Copy link
Contributor

@duong-se duong-se commented Jun 18, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #1748

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1748

What is the new behavior?

  • Remove unuse dependencies
  • Add depencies use to package.json

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from vuhuucuong and willmcvay June 18, 2020 09:22
@github-actions github-actions bot added aml-checklist Relates to Anti-money laundering app cognito-auth Issue relates to Cognito Auth NPM package geo-diary Relates to GEO Diary app graphql-server lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace smb-onboarder Relates to Small Medium Business onboarding app web-components labels Jun 18, 2020
@auto-assign auto-assign bot requested a review from phmngocnghia June 18, 2020 09:22
@duong-se duong-se force-pushed the fix/1748-optimize-pipeline branch from 6f031bf to 5b0deb8 Compare June 18, 2020 09:31
@github-actions github-actions bot requested a review from ant066 June 18, 2020 09:31
@duong-se duong-se merged commit 4dad8c4 into master Jun 18, 2020
@duong-se duong-se deleted the fix/1748-optimize-pipeline branch June 18, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aml-checklist Relates to Anti-money laundering app cognito-auth Issue relates to Cognito Auth NPM package geo-diary Relates to GEO Diary app graphql-server lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace smb-onboarder Relates to Small Medium Business onboarding app web-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up our pipelines by only building the packages at each run under active developement
3 participants