Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #652 Upload CSV should validate before submit #750

Merged
merged 4 commits into from
Mar 30, 2020
Merged

feat: #652 Upload CSV should validate before submit #750

merged 4 commits into from
Mar 30, 2020

Conversation

vuhuucuong
Copy link
Contributor

fixes: #652

  • Add callback props afterUploadDataValidated to run after validating upload data
  • Add modal to show after validating upload data
  • Upload is no longer replace all Spreadsheet, the logic is now customizable in afterUploadDataValidated

@github-actions github-actions bot added elements Relates to Elements components and utilities marketplace Relates to the Marketplace labels Mar 27, 2020
willmcvay
willmcvay approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appreciate the comments and tests too 👍

@github-actions github-actions bot requested a review from willmcvay March 27, 2020 17:05
@github-actions github-actions bot requested review from duong-se and trankhacvy March 30, 2020 03:49
duong-se
duong-se approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a review from duong-se March 30, 2020 04:09
@vuhuucuong vuhuucuong merged commit b917195 into master Mar 30, 2020
@vuhuucuong vuhuucuong deleted the feat/652-upload-csv-should-validate-before-submit branch March 30, 2020 05:12
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
feat: #652 Upload CSV should validate before submit (#750)
25dc1f2 
* feat: #652 upload CSV should validate before submit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leXuanNha leXuanNha Awaiting requested review from leXuanNha

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@willmcvay willmcvay Awaiting requested review from willmcvay

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@duong-se duong-se Awaiting requested review from duong-se

Assignees

@vuhuucuong vuhuucuong

Labels
elements Relates to Elements components and utilities marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uploading a CSV to table should validate data before submitting to server
4 participants
@vuhuucuong @willmcvay @trankhacvy @duong-se