Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading a CSV to table should validate data before submitting to server #652

Closed
willmcvay opened this issue Mar 18, 2020 · 1 comment · Fixed by #750
Closed

Uploading a CSV to table should validate data before submitting to server #652

willmcvay opened this issue Mar 18, 2020 · 1 comment · Fixed by #750
Assignees
Labels
elements Relates to Elements components and utilities feature New feature or request front-end Relates to front end issues smb-onboarder Relates to Small Medium Business onboarding app

Comments

@willmcvay
Copy link
Contributor

Background;

See #651 We will be processing data in a queue when uploading a CSV of records to a table component.

Feature;

To support this, the initial upload should trigger the standard validation for that entity, on each item in the CSV. If errors are found, should show a dialogue asking the user if they want to re-upload or process the valid records only. Yes to proceed to POST / mutation on the filtered list, no to junk the CSV.

Should also validate the maximum size of the CSV - this should be a variable configurable by entity as the optimal max size will vary. Use 30 records as an initial default until we know how it performs.

@willmcvay willmcvay added feature New feature or request smb-onboarder Relates to Small Medium Business onboarding app elements Relates to Elements components and utilities front-end Relates to front end issues labels Mar 18, 2020
@willmcvay willmcvay added this to the SMB App MVP milestone Mar 18, 2020
@nphivu414 nphivu414 self-assigned this Mar 25, 2020
@vuhuucuong vuhuucuong assigned vuhuucuong and unassigned nphivu414 Mar 26, 2020
vuhuucuong pushed a commit that referenced this issue Mar 27, 2020
vuhuucuong pushed a commit that referenced this issue Mar 30, 2020
vuhuucuong pushed a commit that referenced this issue Mar 30, 2020
vuhuucuong pushed a commit that referenced this issue Mar 30, 2020
* feat: #652 upload CSV should validate before submit
@vuhuucuong
Copy link
Contributor

vuhuucuong commented Mar 30, 2020

@HollyJoyPhillips FYI, you can QA this in storybook in here: https://dev.elements.reapit.cloud/?path=/story/spreadsheet--upload-with-validate
In smb, we need to wait for @trankhacvy to integrate it in #651 & #653

nphivu414 pushed a commit that referenced this issue Apr 29, 2020
* feat: #652 upload CSV should validate before submit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elements Relates to Elements components and utilities feature New feature or request front-end Relates to front end issues smb-onboarder Relates to Small Medium Business onboarding app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants