Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #641 #642 #694

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix: #641 #642 #694

merged 1 commit into from
Mar 23, 2020

Conversation

phmngocnghia
Copy link
Contributor

fixes #641 #642

  • Separated cookies for developer's, client's term accepted and first-time login status
  • Separated sagas to manage initial developer's, client's initial term accepted state
  • Close the modal (TermsAndConditionsModal, ClientWelcomeMessageModal) will set term-accepted cookie
  • Press Get Started at the end of step 5 of the welcome page (DeveloperWelcomeMessage, ClientWelcomeMessage) will set first-time-login-complete cookie

@github-actions github-actions bot added the marketplace Relates to the Marketplace label Mar 23, 2020
duong-se
duong-se approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vuhuucuong
vuhuucuong approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@duong-se duong-se merged commit 58578a1 into master Mar 23, 2020
@duong-se duong-se deleted the fix/#641-first-time-log-in-and-terms-accepted-cookies-not-setting-correctly branch March 23, 2020 12:40
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
fix: #641 - First time log in and terms accepted cookies not setting …
6d99a1a 
…correctly (#694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@duong-se duong-se duong-se approved these changes

@dannd4 dannd4 Awaiting requested review from dannd4

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@phmngocnghia phmngocnghia

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First time log in and terms accepted cookies not setting correctly
3 participants
@phmngocnghia @duong-se @vuhuucuong