Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First time log in and terms accepted cookies not setting correctly #641

Closed
HollyJoyPhillips opened this issue Mar 17, 2020 · 0 comments · Fixed by #694
Closed

First time log in and terms accepted cookies not setting correctly #641

HollyJoyPhillips opened this issue Mar 17, 2020 · 0 comments · Fixed by #694
Assignees
@phmngocnghia
Labels
bug Something isn't working front-end Relates to front end issues marketplace Relates to the Marketplace
Milestone
Foundations Beta ...

Comments

@HollyJoyPhillips
Copy link
Contributor

Summary: When a client logs into the Client Portal for the first time they should be presented with a 'Terms and Conditions' modal which when they accept should set a 'reapit-term-accepted' cookie, then they should presented with the 'Welcome Guide' which when completed should set a 'reapit-first-login-complete' cookie.

Current behaviour: When accepting the 'Terms and Conditions' modal it is incorrectly setting the 'reapit-first-login-complete' cookie which means the 'Welcome Guide' doesn't appear

Expected behaviour: Agree/Accept the 'Terms and Conditions' modal, create 'reapit-term-accepted' cookie, be presented with the 'Welcome Guide', click on 'Get Started' on step 5 which should set the 'reapit-first-time-complete' cookie.

Terms:
image

Welcome Guide URL:
https://dev.marketplace.reapit.cloud/client/welcome
@HollyJoyPhillips HollyJoyPhillips added bug Something isn't working marketplace Relates to the Marketplace front-end Relates to front end issues labels Mar 17, 2020
@phmngocnghia phmngocnghia self-assigned this Mar 19, 2020
phmngocnghia pushed a commit that referenced this issue Mar 23, 2020
fix: #641 - First time log in and terms accepted cookies not setting …
b4059d2 
…correctly
@phmngocnghia phmngocnghia mentioned this issue Mar 23, 2020
Merged
duong-se pushed a commit that referenced this issue Mar 23, 2020
fix: #641 - First time log in and terms accepted cookies not setting …
58578a1 
…correctly (#694)
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
fix: #641 - First time log in and terms accepted cookies not setting …
6d99a1a 
…correctly (#694)
@snyk-bot snyk-bot mentioned this issue Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phmngocnghia phmngocnghia

Labels
bug Something isn't working front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Milestone
Foundations Beta Developer Release
Development

Successfully merging a pull request may close this issue.

fix: #641 #642 reapit/foundations
2 participants
@phmngocnghia @HollyJoyPhillips