Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #629 migrate config.json for scaffolder and ts defitions #688

Merged
merged 1 commit into from
Mar 23, 2020
Merged

chore: #629 migrate config.json for scaffolder and ts defitions #688

merged 1 commit into from
Mar 23, 2020

Conversation

duong-se
Copy link
Contributor

Changes

  • Move scripts ts-definitions to correct folder
  • Remove unuse code from fetch definition

@duong-se duong-se changed the title chore: 6#629 refactor for unuse code chore: #629 refactor for unuse code Mar 20, 2020
@github-actions github-actions bot added the config-manager Relates to Config Manager package label Mar 20, 2020
willmcvay
willmcvay requested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we have to leave secrets manager for now until we have a replacement we can document

packages/config-manager/src/index.js Outdated Show resolved Hide resolved
@duong-se duong-se force-pushed the chore/629-config-manager-should-not-reference-local branch from d87decf to 67bc8d3 Compare March 20, 2020 15:47
@github-actions github-actions bot requested a review from willmcvay March 20, 2020 15:47
@github-actions github-actions bot added the react-app-scaffolder Relates to React App Scaffolder package label Mar 20, 2020
@duong-se duong-se force-pushed the chore/629-config-manager-should-not-reference-local branch from 67bc8d3 to 2ddf042 Compare March 20, 2020 15:54
@duong-se duong-se changed the title chore: #629 refactor for unuse code chore: #629 migrate config.json for scaffolder and ts defitions Mar 20, 2020
@duong-se
Copy link
Contributor Author

For the react scaffolder I will retest all again by this issue #568

chore: #629 migrate to config.json for fts-definitions & scaffolder
2630a0b 
Changes
- Migrate to config.json for ts definitions
- Migrate to config.json for react scaffolder
@duong-se duong-se force-pushed the chore/629-config-manager-should-not-reference-local branch from 2ddf042 to 2630a0b Compare March 20, 2020 16:05
@duong-se duong-se merged commit cd59f3e into master Mar 23, 2020
@duong-se duong-se deleted the chore/629-config-manager-should-not-reference-local branch March 23, 2020 02:31
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
chore: #629 migrate to config.json for fts-definitions & scaffolder (#…
297a800 
…688)

Changes
- Migrate to config.json for ts definitions
- Migrate to config.json for react scaffolder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nphivu414 nphivu414 nphivu414 approved these changes

@willmcvay willmcvay willmcvay approved these changes

@dannd4 dannd4 Awaiting requested review from dannd4

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

Assignees

@duong-se duong-se

Labels
config-manager Relates to Config Manager package react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duong-se @willmcvay @nphivu414