Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config manager should not reference local config #629

Closed
willmcvay opened this issue Mar 16, 2020 · 1 comment
Closed

Config manager should not reference local config #629

willmcvay opened this issue Mar 16, 2020 · 1 comment
Assignees
Labels
config-manager Relates to Config Manager package enhancements Relates to a feature enhancement front-end Relates to front end issues

Comments

@willmcvay
Copy link
Contributor

The current config manager update function makes it too easy to override the remote config.

Currently;

  • Fetches remote config, copies local config, then merges and pushes. This means a stale local config can override a newer remote.

Should;

  • Fetch remote config, user should make their changes manually to this file and push.

Or;

  • Better still, diff changes and give a command prompt for each change asking the user to confirm each one is correct. This should prevent accidental overrides.
@willmcvay willmcvay added config-manager Relates to Config Manager package enhancements Relates to a feature enhancement front-end Relates to front end issues labels Mar 16, 2020
@duong-se
Copy link
Contributor

duong-se commented Mar 17, 2020

to avoid this I think we should separate local, production and, dev environment to 3 secrets management and we should update on AWS instead of run CLI

@duong-se duong-se self-assigned this Mar 17, 2020
duong-se pushed a commit that referenced this issue Mar 19, 2020
chore: #629 migrate config of apps to config.json (#644)
duong-se pushed a commit that referenced this issue Mar 20, 2020
Changes
- Migrate for web-components
- Migrate for smb
- Migrate for cognito custom mail lambda
- Migrate for cognito auth
duong-se pushed a commit that referenced this issue Mar 20, 2020
Changes
- Migrate for web-components
- Migrate for smb
- Migrate for cognito custom mail lambda
- Migrate for cognito auth
duong-se pushed a commit that referenced this issue Mar 20, 2020
Changes
- Migrate to config.json for ts definitions
- Migrate to config.json for react scaffolder
duong-se pushed a commit that referenced this issue Mar 23, 2020
…688)

Changes
- Migrate to config.json for ts definitions
- Migrate to config.json for react scaffolder
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
chore: #629 migrate config of apps to config.json (#644)
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
Changes
- Migrate for web-components
- Migrate for smb
- Migrate for cognito custom mail lambda
- Migrate for cognito auth
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
…688)

Changes
- Migrate to config.json for ts definitions
- Migrate to config.json for react scaffolder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-manager Relates to Config Manager package enhancements Relates to a feature enhancement front-end Relates to front end issues
Projects
None yet
Development

No branches or pull requests

2 participants