Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #128 remove redundant and restructure dependencies #451

Merged
merged 5 commits into from
Feb 27, 2020
Merged

chore: #128 remove redundant and restructure dependencies #451

merged 5 commits into from
Feb 27, 2020

Conversation

duong-se
Copy link
Contributor

@duong-se duong-se commented Feb 27, 2020 •
edited
Loading

fixes: #128

  • Remove redundant dependencies and restructure
  • Resolve some warning when building and install

@duong-se duong-se force-pushed the fix/128-clean-up-dependencies branch from 19875a4 to 178d544 Compare February 27, 2020 06:09
@github-actions github-actions bot added aml-checklist Relates to Anti-money laundering app cognito-auth Issue relates to Cognito Auth NPM package cognito-custom-mail-lambda elements Relates to Elements components and utilities geo-diary Relates to GEO Diary app graphql-server lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace react-app-scaffolder Relates to React App Scaffolder package smb-onboarder Relates to Small Medium Business onboarding app web-components labels Feb 27, 2020
willmcvay
willmcvay reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good. Are you still looking at the errors? let me know if you need me to approve

@duong-se duong-se force-pushed the fix/128-clean-up-dependencies branch from a43273a to 021d51a Compare February 27, 2020 16:07
@github-actions github-actions bot requested a review from willmcvay February 27, 2020 16:07
willmcvay
willmcvay approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@duong-se duong-se force-pushed the fix/128-clean-up-dependencies branch from f84158d to 0acafba Compare February 27, 2020 16:22
@github-actions github-actions bot requested a review from willmcvay February 27, 2020 16:22
@willmcvay willmcvay merged commit c6a4c53 into master Feb 27, 2020
@willmcvay willmcvay deleted the fix/128-clean-up-dependencies branch February 27, 2020 18:14
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@duong-se
chore: #128 remove redundant and restructure dependencies (#451)
c981027 
* chore: #128 remove redundant and restructure dependencies

* chore: resolve all warning on build console

* chore: resolve warning peer dependencies for install by yarn

* fix: resolve package cognito-auth in cognito package

* chore: remove query-string dependency
@willmcvay willmcvay mentioned this pull request Mar 10, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 13, 2021
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannd4 dannd4 Awaiting requested review from dannd4

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@duong-se duong-se

Labels
aml-checklist Relates to Anti-money laundering app cognito-auth Issue relates to Cognito Auth NPM package cognito-custom-mail-lambda elements Relates to Elements components and utilities geo-diary Relates to GEO Diary app graphql-server lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace react-app-scaffolder Relates to React App Scaffolder package smb-onboarder Relates to Small Medium Business onboarding app web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Our NPM dependencies need reviewing
2 participants
@duong-se @willmcvay