Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our NPM dependencies need reviewing #128

Closed
willmcvay opened this issue Jan 29, 2020 · 0 comments · Fixed by #451
Closed

Our NPM dependencies need reviewing #128

willmcvay opened this issue Jan 29, 2020 · 0 comments · Fixed by #451
Assignees
@duong-se
Labels
chore Maintenance or housekeeping tasks foundations Issues relating to Foundations front-end Relates to front end issues
Milestone
Foundations Beta ...

Comments

@willmcvay
Copy link
Contributor

  • Our NPM dependencies throw a large number of warnings on a clean install. This should be tidied up and the warnings addressed.
  • In some cases, there are packages that are no longer in use and can be deleted.
  • Should upgrade to latest patched (minor, not major) versions where possible and without breaking changes
@willmcvay willmcvay added chore Maintenance or housekeeping tasks foundations Issues relating to Foundations labels Jan 29, 2020
@HollyJoyPhillips HollyJoyPhillips added the front-end Relates to front end issues label Feb 10, 2020
@duong-se duong-se self-assigned this Feb 26, 2020
@duong-se duong-se mentioned this issue Feb 27, 2020
Merged
2 tasks
duong-se pushed a commit that referenced this issue Feb 27, 2020
chore: #128 remove redundant and restructure dependencies
e4479c7
willmcvay pushed a commit that referenced this issue Feb 27, 2020
@duong-se
chore: #128 remove redundant and restructure dependencies (#451)
c6a4c53 
* chore: #128 remove redundant and restructure dependencies

* chore: resolve all warning on build console

* chore: resolve warning peer dependencies for install by yarn

* fix: resolve package cognito-auth in cognito package

* chore: remove query-string dependency
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@duong-se
chore: #128 remove redundant and restructure dependencies (#451)
c981027 
* chore: #128 remove redundant and restructure dependencies

* chore: resolve all warning on build console

* chore: resolve warning peer dependencies for install by yarn

* fix: resolve package cognito-auth in cognito package

* chore: remove query-string dependency
@willmcvay willmcvay mentioned this issue Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duong-se duong-se

Labels
chore Maintenance or housekeeping tasks foundations Issues relating to Foundations front-end Relates to front end issues
Projects
None yet
Milestone
Foundations Beta Developer Release
Development

Successfully merging a pull request may close this issue.

chore: #128 remove redundant and restructure dependencies reapit/foundations
3 participants
@willmcvay @duong-se @HollyJoyPhillips