Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #422 - re-add internal scaffolder option on cli to app scaffolder #448

Conversation

phmngocnghia
Copy link
Contributor

fixes #422

@github-actions github-actions bot added the react-app-scaffolder Relates to React App Scaffolder package label Feb 26, 2020
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 👍

Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phmngocnghia phmngocnghia merged commit 2a370f8 into master Feb 27, 2020
@phmngocnghia phmngocnghia deleted the chore/422-re-add-internal-scaffold-option-on-cli-to-app-scaffolder branch February 27, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-add internal scaffold option on CLI to App Scaffolder
3 participants