Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add internal scaffold option on CLI to App Scaffolder #422

Closed
willmcvay opened this issue Feb 24, 2020 · 1 comment · Fixed by #448 or #645
Closed

Re-add internal scaffold option on CLI to App Scaffolder #422

willmcvay opened this issue Feb 24, 2020 · 1 comment · Fixed by #448 or #645
Assignees
@phmngocnghia
Labels
feature New feature or request front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package
Milestone
Foundations Beta ...

Comments

@willmcvay
Copy link
Contributor

  • Had to comment out internal scaffold option for launch
  • Re-add CLI option
  • Most of the work should be in package json
  • Should be re-factored in line with new changes
  • Tests should pass, build for prod and dev should work for all 4 options (redux, non-redux, CSS, Styled Components).
  • Needs a lot of local testing before going live on NPM
@willmcvay willmcvay added feature New feature or request react-app-scaffolder Relates to React App Scaffolder package front-end Relates to front end issues labels Feb 24, 2020
@phmngocnghia phmngocnghia self-assigned this Feb 25, 2020
phmngocnghia pushed a commit that referenced this issue Feb 26, 2020
chore: #422 - re-add internal scaffolder option on cli to app scaffolder
24dbb3e
@phmngocnghia phmngocnghia mentioned this issue Feb 26, 2020
Merged
phmngocnghia pushed a commit that referenced this issue Feb 27, 2020
chore: #422 - re-add internal scaffolder option on cli to app scaffol…
2a370f8 
…der (#448)
@willmcvay
Copy link
Contributor Author

@phmngocnghia Tested this finally and got a couple of errors. See screenshots for the options I used.

Can you look into please?

Screenshot 2020-03-16 at 11 37 47

Screenshot 2020-03-16 at 11 38 04

@willmcvay willmcvay reopened this Mar 16, 2020
phmngocnghia pushed a commit that referenced this issue Mar 18, 2020
fix: #422 - Re-add internal scaffold option on CLI to App Scaffolder
bbe59c8
@phmngocnghia phmngocnghia mentioned this issue Mar 18, 2020
Merged
duong-se pushed a commit that referenced this issue Mar 19, 2020
fix: #422 - Re-add internal scaffold option on CLI to App Scaffolder (#…
bd14740 
…645)
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
chore: #422 - re-add internal scaffolder option on cli to app scaffol…
7500c56 
…der (#448)
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
fix: #422 - Re-add internal scaffold option on CLI to App Scaffolder (#…
09ca30c 
…645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phmngocnghia phmngocnghia

Labels
feature New feature or request front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Milestone
Foundations Beta Developer Release
2 participants
@willmcvay @phmngocnghia