Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #2581 Update the ‘Existing Subscription’ modal for Developer Edition #2585

Merged
merged 2 commits into from
Sep 7, 2020
Merged

feat: #2581 Update the ‘Existing Subscription’ modal for Developer Edition #2585

merged 2 commits into from
Sep 7, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented Sep 7, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #2581

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Screen Shot 2020-09-07 at 10 41 45

Issue Number: #2581

What is the new behavior?

Screen Shot 2020-09-07 at 10 41 05

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ant066 ant066 force-pushed the feat/2581-update-existing-subscription-modal branch from 222f674 to 3ab59cc Compare September 7, 2020 06:36
@github-actions github-actions bot requested a review from vuhuucuong September 7, 2020 06:56
duong-se
duong-se approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit bf5a1f4 into master Sep 7, 2020
@duong-se duong-se deleted the feat/2581-update-existing-subscription-modal branch September 7, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmngocnghia phmngocnghia phmngocnghia approved these changes

@duong-se duong-se duong-se approved these changes

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

Assignees

@ant066 ant066

Labels
developer-portal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the ‘Existing Subscription’ modal for Developer Edition
3 participants
@ant066 @duong-se @phmngocnghia