Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2391 Add some logs to debug infinite scrolling issues on dev #2433

Conversation

nphivu414
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2391

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2391

What is the new behavior?

  • Add some logs to debug infinite scrolling issues on dev

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from ant066 and willmcvay August 21, 2020 04:46
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Aug 21, 2020
@auto-assign auto-assign bot requested review from duong-se and vuhuucuong August 21, 2020 04:47
@duong-se duong-se merged commit a046098 into master Aug 21, 2020
@duong-se duong-se deleted the fix/2391-browse-app-page-scrolling-is-disabled-when-not-over-app-list branch August 21, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browse apps page scrolling is disabled when not over the apps list
3 participants