Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse apps page scrolling is disabled when not over the apps list #2391

Closed
willmcvay opened this issue Aug 18, 2020 · 1 comment · Fixed by #2409, #2413, #2419, #2421 or #2425
Closed

Browse apps page scrolling is disabled when not over the apps list #2391

willmcvay opened this issue Aug 18, 2020 · 1 comment · Fixed by #2409, #2413, #2419, #2421 or #2425
Assignees
@nphivu414
Labels
bug Something isn't working front-end Relates to front end issues marketplace Relates to the Marketplace
Milestone
Marketplace Web P...

Comments

@willmcvay
Copy link
Contributor

Background context or User story:

When scrolling on the browse apps page, if my cursor is over the main container (ie not over the apps tiles), I can't scroll.

Specification or Acceptance Criteria:

  • I should be able to scroll anywhere in the main page container

Suggested solution:

  • I have raised at least 4 bugs on this now. On each one, I said, please disable the scrolling on the apps list container and allow the main page container to scroll as we do on every page. This is the solution.
@willmcvay willmcvay added feature New feature or request front-end Relates to front end issues bug Something isn't working marketplace Relates to the Marketplace and removed feature New feature or request labels Aug 18, 2020
@vuhuucuong vuhuucuong self-assigned this Aug 18, 2020
@vuhuucuong vuhuucuong removed their assignment Aug 18, 2020
@nphivu414 nphivu414 self-assigned this Aug 19, 2020
nphivu414 pushed a commit that referenced this issue Aug 19, 2020
feature: #2391 Fix main container scrolling issues
e021b3c
nphivu414 pushed a commit that referenced this issue Aug 19, 2020
fix: #2391: Update apps infinite scroll behavior
d19e2cf
nphivu414 pushed a commit that referenced this issue Aug 19, 2020
feature: #2391 Fix app list styles - Update tests
ccc7c46
nphivu414 pushed a commit that referenced this issue Aug 19, 2020
fix: #2391: Update tests
618039d
@nphivu414 nphivu414 mentioned this issue Aug 19, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 19, 2020
fix: #2391: Fix lint errors
4c63920
nphivu414 pushed a commit that referenced this issue Aug 20, 2020
fix: #2391: Fix typo errors
ebea011
nphivu414 pushed a commit that referenced this issue Aug 20, 2020
fix: #2391 Browse app page scrolling is disabled when not over app li…
9fdbcc5 
…st (#2409)
@nphivu414 nphivu414 mentioned this issue Aug 20, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 20, 2020
fix: #2391 Add default threshold for apps infinite scroll (#2413)
f84a2ff
@nphivu414 nphivu414 mentioned this issue Aug 20, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 20, 2020
fix: #2391 Add some logs to debug infinite scrolling issues on dev (#…
b775569 
…2419)
@nphivu414 nphivu414 mentioned this issue Aug 20, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 20, 2020
fix: #2391 Add some logs to debug infinite scrolling issues on dev (#…
b691360 
…2421)
@nphivu414 nphivu414 mentioned this issue Aug 20, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 20, 2020
fix: #2391 Add some logs to debug infinite scrolling issues on dev (#…
45c6764 
…2425)
@nphivu414 nphivu414 mentioned this issue Aug 21, 2020
Merged
14 tasks
duong-se pushed a commit that referenced this issue Aug 21, 2020
fix: #2391 Add some logs to debug infinite scrolling issues on dev (#…
a046098 
…2433)
@nphivu414 nphivu414 mentioned this issue Aug 21, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 21, 2020
fix: #2391 Add some logs to debug infinite scrolling issues on dev (#…
f467fc0 
…2436)
@nphivu414 nphivu414 mentioned this issue Aug 24, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 24, 2020
fix: #2391 Browse app page scrolling is disabled when not over app li…
d11f2b2 
…st (#2444)
@nphivu414 nphivu414 mentioned this issue Aug 24, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 24, 2020
fix: #2391 browse app page scrolling is disabled when not over app li…
dac1514 
…st (#2449)
@willmcvay
Copy link
Contributor Author

Screen Recording 2020-08-24 at 08.11.09.mov 2.zip

Please test to ensure this has been fixed!

@willmcvay willmcvay reopened this Aug 24, 2020
@nphivu414 nphivu414 mentioned this issue Aug 24, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Aug 24, 2020
fix: #2391 Update tests + remove logs (#2454)
0fbdc72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nphivu414 nphivu414

Labels
bug Something isn't working front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Milestone
Marketplace Web Production Release
Development

Successfully merging a pull request may close this issue.

fix: #2391 Browse app page scrolling is disabled when not over app list reapit/foundations
fix: #2391 Add default threshold for apps infinite scroll reapit/foundations
fix: #2391 Add some logs to debug infinite scrolling issues on dev reapit/foundations
fix: #2391 Add some logs to debug infinite scrolling issues on dev reapit/foundations
fix: #2391 Add some logs to debug infinite scrolling issues on dev reapit/foundations
fix: #2391 Add some logs to debug infinite scrolling issues on dev reapit/foundations
fix: #2391 Add some logs to debug infinite scrolling issues on dev reapit/foundations
fix: #2391 Browse app page scrolling is disabled when not over app list reapit/foundations
fix: #2391 browse app page scrolling is disabled when not over app list reapit/foundations
fix: #2391 Update tests + remove logs reapit/foundations
3 participants
@willmcvay @nphivu414 @vuhuucuong