Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1468 client standalone ui update #1560

Merged
merged 5 commits into from
Jun 4, 2020

Conversation

vuhuucuong
Copy link
Contributor

@vuhuucuong vuhuucuong commented Jun 4, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #1468

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1468

What is the new behavior?

  • On mobile:
    z1911035997912_2487a5868644751ce30d887eba16efe1

  • On desktop:

Screen Shot 2020-06-04 at 16 37 06

Does this introduce a breaking change?

  • Yes
  • No

Other information

Include some css layout bug fixes

@github-actions github-actions bot requested review from ant066 and willmcvay June 4, 2020 09:33
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jun 4, 2020
@auto-assign auto-assign bot requested review from phmngocnghia and duong-se June 4, 2020 09:35
@github-actions github-actions bot requested review from trankhacvy and duong-se June 4, 2020 10:07
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vuhuucuong vuhuucuong force-pushed the fix/1468-client-standalone-ui-update branch from cbc3f04 to 85d2539 Compare June 4, 2020 11:07
@github-actions github-actions bot requested a review from nphivu414 June 4, 2020 11:07
@vuhuucuong vuhuucuong merged commit 12a2c56 into master Jun 4, 2020
@vuhuucuong vuhuucuong deleted the fix/1468-client-standalone-ui-update branch June 4, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Standalone UI Updates
3 participants