Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Standalone UI Updates #1468

Closed
HollyJoyPhillips opened this issue Jun 1, 2020 · 2 comments · Fixed by #1560
Closed

Client Standalone UI Updates #1468

HollyJoyPhillips opened this issue Jun 1, 2020 · 2 comments · Fixed by #1560
Assignees
Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues marketplace Relates to the Marketplace

Comments

@HollyJoyPhillips
Copy link
Contributor

HollyJoyPhillips commented Jun 1, 2020

Summary: This ticket is to address a few small UI fixes for the client standalone apps (including mobile)

  • Show Direct API heading if 'Yes'
    See Dev GEO Diary has Direct API set as 'Yes' but the heading does not show on the client side:
    GEO

image

Mobile

  • The icon image and featured image are not scaling, see mobile screenshot below:
    image

image

@HollyJoyPhillips HollyJoyPhillips added marketplace Relates to the Marketplace enhancements Relates to a feature enhancement front-end Relates to front end issues labels Jun 1, 2020
@vuhuucuong vuhuucuong self-assigned this Jun 3, 2020
@vuhuucuong
Copy link
Contributor

vuhuucuong commented Jun 4, 2020

Hi, @HollyJoyPhillips I have a few questions:

  • Should we show the (Direct API) at this place, or somewhere else?

Screen Shot 2020-06-04 at 10 48 37

  • Do you want the image to be cropped at the center like this

Screen Shot 2020-06-04 at 11 10 43

Or scale like this

Screen Shot 2020-06-04 at 11 11 45

IMO I think it should be cropped at the center, because if user uploads an image with ratio like 10:3 and we use auto scaling, it will look ugly in our site

@HollyJoyPhillips
Copy link
Contributor Author

@vuhuucuong Cropped at the centre looks better, I agree. Direct API should show as a heading down the left hand side under 'Desktop Integration' as a separate heading only if it is 'Yes' please. Thank you.

vuhuucuong pushed a commit that referenced this issue Jun 4, 2020
vuhuucuong pushed a commit that referenced this issue Jun 4, 2020
vuhuucuong pushed a commit that referenced this issue Jun 4, 2020
vuhuucuong pushed a commit that referenced this issue Jun 4, 2020
vuhuucuong pushed a commit that referenced this issue Jun 4, 2020
vuhuucuong pushed a commit that referenced this issue Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants