Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1422 IE bugs fix client portal #1471

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix: #1422 IE bugs fix client portal #1471

merged 1 commit into from
Jun 2, 2020

Conversation

vuhuucuong
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #1442

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1422

What is the new behavior?

  • Fixed navigation

1

- Fixed `LeadPro` app (long text issue)

2

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vuhuucuong vuhuucuong changed the title fix: #1422 IE bug fixed fix: #1422 IE bugs fix Jun 1, 2020
@github-actions github-actions bot added elements Relates to Elements components and utilities marketplace Relates to the Marketplace labels Jun 1, 2020
@vuhuucuong vuhuucuong changed the title fix: #1422 IE bugs fix fix: #1422 IE bugs fix client portal Jun 1, 2020
duong-se
duong-se approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 4267c15 into master Jun 2, 2020
@duong-se duong-se deleted the fix/1422-client-portal-testing-fix branch June 2, 2020 03:16
@snyk-bot snyk-bot mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se approved these changes

@willmcvay willmcvay willmcvay approved these changes

@ant066 ant066 Awaiting requested review from ant066

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

Assignees

@vuhuucuong vuhuucuong

Labels
elements Relates to Elements components and utilities marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuhuucuong @willmcvay @duong-se