Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: #1327 refactor Admin Stats using new react-redux hooks #1442

Merged
merged 3 commits into from
Jun 3, 2020
Merged

refactor: #1327 refactor Admin Stats using new react-redux hooks #1442

merged 3 commits into from
Jun 3, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented May 29, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1327

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vuhuucuong vuhuucuong mentioned this pull request Jun 1, 2020
Merged
14 tasks
willmcvay
willmcvay approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

duong-se
duong-se approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ant066 ant066 reopened this Jun 2, 2020
@github-actions github-actions bot requested review from duong-se and willmcvay June 2, 2020 11:31
@github-actions github-actions bot added aml-checklist Relates to Anti-money laundering app geo-diary Relates to GEO Diary app lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace labels Jun 2, 2020
@ant066 ant066 merged commit 3a535c3 into master Jun 3, 2020
@ant066 ant066 deleted the refactor/1327-admin-stats branch June 3, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@duong-se duong-se Awaiting requested review from duong-se

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@ant066 ant066

Labels
aml-checklist Relates to Anti-money laundering app geo-diary Relates to GEO Diary app lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ant066 @willmcvay @duong-se